Use canUsePrivateNotes pattern instead of beta flag

Replace isBetaEnabled(CONST.BETAS.PRIVATE_NOTES) with a
Permissions.canUsePrivateNotes() function that returns false,
following the same pattern as canUseLinkPreviews. This avoids
needing a backend beta configuration.

Co-authored-by: Cong Pham <suneox@users.noreply.github.com>

Author: MelvinBot

src/CONST/index.ts

@@ -887,7 +887,6 @@ const CONST = {
         BULK_EDIT: 'bulkEdit',
         NEW_MANUAL_EXPENSE_FLOW: 'newManualExpenseFlow',
         BULK_SUBMIT_APPROVE_PAY: 'bulkSubmitApprovePay',
-        PRIVATE_NOTES: 'privateNotes',
     },
     BUTTON_STATES: {
         DEFAULT: 'default',

src/libs/Permissions.ts

@@ -35,8 +35,16 @@ function canUseTrackFlows(): boolean {
     return false;
 }
 
+/**
+ * Private notes are temporarily disabled.
+ */
+function canUsePrivateNotes(): boolean {
+    return false;
+}
+
 export default {
     canUseLinkPreviews,
     canUseTrackFlows,
+    canUsePrivateNotes,
     isBetaEnabled,
 };

src/pages/ProfilePage.tsx

@@ -21,11 +21,11 @@ import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'
 import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
-import usePermissions from '@hooks/usePermissions';
 import useThemeStyles from '@hooks/useThemeStyles';
 import createDynamicRoute from '@libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute';
 import Navigation from '@libs/Navigation/Navigation';
 import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
+import Permissions from '@libs/Permissions';
 import {getDisplayNameOrDefault, getPhoneNumber} from '@libs/PersonalDetailsUtils';
 import {
     findSelfDMReportID,
@@ -91,7 +91,6 @@ function ProfilePage({route}: ProfilePageProps) {
 
     const styles = useThemeStyles();
     const {translate, formatPhoneNumber} = useLocalize();
-    const {isBetaEnabled} = usePermissions();
 
     const isValidAccountID = isValidAccountRoute(accountID);
     const loginParams = route.params?.login;
@@ -268,7 +267,7 @@ function ProfilePage({route}: ProfilePageProps) {
                                 }}
                             />
                         )}
-                        {isBetaEnabled(CONST.BETAS.PRIVATE_NOTES) && !isEmptyObject(report) && !!report.reportID && !isCurrentUser && (
+                        {Permissions.canUsePrivateNotes() && !isEmptyObject(report) && !!report.reportID && !isCurrentUser && (
                             <MenuItem
                                 title={`${translate('privateNotes.title')}`}
                                 titleStyle={styles.flex1}

src/pages/ReportDetailsPage.tsx

@@ -38,7 +38,6 @@ import useNetwork from '@hooks/useNetwork';
 import useOnyx from '@hooks/useOnyx';
 import usePaginatedReportActions from '@hooks/usePaginatedReportActions';
 import useParentReportAction from '@hooks/useParentReportAction';
-import usePermissions from '@hooks/usePermissions';
 import usePreferredPolicy from '@hooks/usePreferredPolicy';
 import useReportAttributes from '@hooks/useReportAttributes';
 import useReportIsArchived from '@hooks/useReportIsArchived';
@@ -163,7 +162,6 @@ type CaseID = ValueOf<typeof CASES>;
 function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetailsPageProps) {
     const {translate, localeCompare, formatPhoneNumber} = useLocalize();
     const {isOffline} = useNetwork();
-    const {isBetaEnabled} = usePermissions();
     const {isRestrictedToPreferredPolicy, preferredPolicyID} = usePreferredPolicy();
     const activePolicy = useActivePolicy();
     const styles = useThemeStyles();
@@ -325,16 +323,14 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail
     const reportAttributes = useReportAttributes();
     const isWorkspaceChat = useMemo(() => isWorkspaceChatUtil(report?.chatType ?? ''), [report?.chatType]);
 
-    const isPrivateNotesEnabled = isBetaEnabled(CONST.BETAS.PRIVATE_NOTES);
-
     useEffect(() => {
-        // Do not fetch private notes if the beta is disabled, isLoadingPrivateNotes is already defined, the network is offline, or if the report is a self DM.
-        if (!isPrivateNotesEnabled || isPrivateNotesFetchTriggered || isOffline || isSelfDM) {
+        // Do not fetch private notes if the feature is disabled, isLoadingPrivateNotes is already defined, the network is offline, or if the report is a self DM.
+        if (!Permissions.canUsePrivateNotes() || isPrivateNotesFetchTriggered || isOffline || isSelfDM) {
             return;
         }
 
         getReportPrivateNote(report?.reportID);
-    }, [report?.reportID, isOffline, isPrivateNotesFetchTriggered, isSelfDM, isPrivateNotesEnabled]);
+    }, [report?.reportID, isOffline, isPrivateNotesFetchTriggered, isSelfDM]);
 
     const leaveChat = useCallback(() => {
         if (isRootGroupChat) {
@@ -530,8 +526,8 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail
             }
         }
 
-        // Prevent displaying private notes option for threads and task reports, or when the beta is disabled
-        if (isBetaEnabled(CONST.BETAS.PRIVATE_NOTES) && !isChatThread && !isMoneyRequestReport && !isInvoiceReport && !isTaskReport) {
+        // Prevent displaying private notes option for threads and task reports, or when the feature is disabled
+        if (Permissions.canUsePrivateNotes() && !isChatThread && !isMoneyRequestReport && !isInvoiceReport && !isTaskReport) {
             items.push({
                 key: CONST.REPORT_DETAILS_MENU_ITEM.PRIVATE_NOTES,
                 translationKey: 'privateNotes.title',
@@ -655,7 +651,6 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail
         ownerBillingGracePeriodEnd,
         iouTransaction,
         delegateEmail,
-        isBetaEnabled,
     ]);
 
     const displayNamesWithTooltips = useMemo(() => {