simplify pushModifiedExpenseNotification to always use getForReportActionTemp

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: leshniak

src/libs/Notification/LocalNotification/BrowserNotifications.ts

@@ -5,7 +5,7 @@ import EXPENSIFY_ICON_URL from '@assets/images/expensify-logo-round-clearspace.p
 import * as AppUpdate from '@libs/actions/AppUpdate';
 // eslint-disable-next-line @typescript-eslint/no-deprecated -- translateLocal is deprecated; BrowserNotifications is non-React code that cannot use the translate hook
 import {translateLocal} from '@libs/Localize';
-import {getForReportAction, getForReportActionTemp} from '@libs/ModifiedExpenseMessage';
+import {getForReportActionTemp} from '@libs/ModifiedExpenseMessage';
 import {getTextFromHtml} from '@libs/ReportActionsUtils';
 import * as ReportUtils from '@libs/ReportUtils';
 import playSound, {SOUNDS} from '@libs/Sound';
@@ -144,23 +144,16 @@ export default {
         currentUserLogin,
     }: LocalNotificationModifiedExpensePushParams) {
         const title = reportAction.person?.map((f) => f.text).join(', ') ?? '';
-        const body = policyTags
-            ? getForReportActionTemp({
-                  // eslint-disable-next-line @typescript-eslint/no-deprecated -- translateLocal is deprecated; BrowserNotifications is non-React code that cannot use the translate hook
-                  translate: translateLocal,
-                  reportAction,
-                  policy,
-                  movedFromReport,
-                  movedToReport,
-                  policyTags,
-                  currentUserLogin,
-              })
-            : getForReportAction({
-                  reportAction,
-                  policyID: report.policyID,
-                  movedFromReport,
-                  movedToReport,
-              });
+        const body = getForReportActionTemp({
+            // eslint-disable-next-line @typescript-eslint/no-deprecated -- translateLocal is deprecated; BrowserNotifications is non-React code that cannot use the translate hook
+            translate: translateLocal,
+            reportAction,
+            policy,
+            movedFromReport,
+            movedToReport,
+            policyTags,
+            currentUserLogin,
+        });
         const icon = usesIcon ? EXPENSIFY_ICON_URL : '';
         const data = {
             reportID: report.reportID,

src/libs/Notification/LocalNotification/index.ts

@@ -6,8 +6,8 @@ import BrowserNotifications from './BrowserNotifications';
 import type {LocalNotificationClickHandler, LocalNotificationModifiedExpenseParams, LocalNotificationModule} from './types';
 
 let allPolicies: OnyxCollection<Policy>;
-// We do not depend on updates on the UI for notifications, so we can use `connectWithoutView` here.
-// This is a temporary subscription until the modified-expense notification chain is fully migrated; see https://github.com/Expensify/App/issues/66336
+// This is a temporary subscription until the modified-expense notification chain is fully migrated
+// see https://github.com/Expensify/App/issues/66336
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY,
     waitForCollectionCallback: true,
@@ -17,8 +17,8 @@ Onyx.connectWithoutView({
 });
 
 let allPolicyTags: OnyxCollection<PolicyTagLists>;
-// We do not depend on updates on the UI for notifications, so we can use `connectWithoutView` here.
-// This is a temporary subscription until the modified-expense notification chain is fully migrated; see https://github.com/Expensify/App/issues/66336
+// This is a temporary subscription until the modified-expense notification chain is fully migrated
+// see https://github.com/Expensify/App/issues/66336
 Onyx.connectWithoutView({
     key: ONYXKEYS.COLLECTION.POLICY_TAGS,
     waitForCollectionCallback: true,