Skip to content

Commit 56ab8be

Browse files
76268: Fixed Onboarding - URL entered as Last Name is accepted but not validated
1 parent 85231c0 commit 56ab8be

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
1818
import {addErrorMessage} from '@libs/ErrorUtils';
1919
import {navigateAfterOnboardingWithMicrotaskQueue} from '@libs/navigateAfterOnboarding';
2020
import Navigation from '@libs/Navigation/Navigation';
21+
import {hasURL} from '@libs/Url';
2122
import {isCurrentUserValidated} from '@libs/UserUtils';
2223
import {doesContainReservedWord, isValidDisplayName} from '@libs/ValidationUtils';
2324
import {clearPersonalDetailsDraft, setPersonalDetails} from '@userActions/Onboarding';
@@ -145,7 +146,9 @@ function BaseOnboardingPersonalDetails({currentUserPersonalDetails, shouldUseNat
145146
}
146147

147148
// Then we validate the last name field
148-
if (!isValidDisplayName(values.lastName)) {
149+
if (hasURL(values.lastName)) {
150+
addErrorMessage(errors, 'lastName', translate('personalDetails.error.hasInvalidCharacter'));
151+
} else if (!isValidDisplayName(values.lastName)) {
149152
addErrorMessage(errors, 'lastName', translate('personalDetails.error.hasInvalidCharacter'));
150153
} else if (values.lastName.length > CONST.DISPLAY_NAME.MAX_LENGTH) {
151154
addErrorMessage(errors, 'lastName', translate('common.error.characterLimitExceedCounter', {length: values.lastName.length, limit: CONST.DISPLAY_NAME.MAX_LENGTH}));

0 commit comments

Comments
 (0)