Skip to content

Commit 5946297

Browse files
MelvinBotJulesssss
andcommitted
Auto-check NO QA Mobile-Expensify PRs in deploy checklist
Fetch Mobile-Expensify PR data and mark [NO QA] titled ones as verified, matching the existing behavior for App PRs. Co-authored-by: Jules <Julesssss@users.noreply.github.com>
1 parent d7ecc95 commit 5946297

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/libs/DeployChecklistUtils.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,12 @@ async function generateDeployChecklistBodyAndAssignees({
172172
const noQAPRNumbers = Array.isArray(data) ? data.filter((PR) => /\[No\s?QA]/i.test(PR.title)).map((item) => item.number) : [];
173173
console.log('Found the following NO QA PRs:', noQAPRNumbers);
174174

175+
const mobileExpensifyData = PRListMobileExpensify.length > 0 ? await GithubUtils.fetchAllPullRequests(PRListMobileExpensify, CONST.MOBILE_EXPENSIFY_REPO) : [];
176+
const noQAMobileExpensifyPRNumbers = Array.isArray(mobileExpensifyData) ? mobileExpensifyData.filter((PR) => /\[No\s?QA]/i.test(PR.title)).map((item) => item.number) : [];
177+
console.log('Found the following NO QA Mobile-Expensify PRs:', noQAMobileExpensifyPRNumbers);
178+
175179
const verifiedAppPRs = new Set([...verifiedPRList, ...noQAPRNumbers]);
176-
const verifiedMobileExpensifyPRs = new Set(verifiedPRListMobileExpensify);
180+
const verifiedMobileExpensifyPRs = new Set([...verifiedPRListMobileExpensify, ...noQAMobileExpensifyPRNumbers]);
177181
const resolvedInternalQAPRSet = new Set(resolvedInternalQAPRs);
178182
const resolvedDeployBlockerSet = new Set(resolvedDeployBlockers);
179183

.github/libs/GithubUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ class GithubUtils {
133133
/**
134134
* Fetch all pull requests given a list of PR numbers.
135135
*/
136-
static fetchAllPullRequests(pullRequestNumbers: number[]): Promise<OctokitPR[] | void> {
136+
static fetchAllPullRequests(pullRequestNumbers: number[], repo: string = CONST.APP_REPO): Promise<OctokitPR[] | void> {
137137
const oldestPR = pullRequestNumbers.sort((a, b) => a - b).at(0);
138138
return this.paginate(
139139
this.octokit.pulls.list,
140140
{
141141
owner: CONST.GITHUB_OWNER,
142-
repo: CONST.APP_REPO,
142+
repo,
143143
state: 'all',
144144
sort: 'created',
145145
direction: 'desc',

0 commit comments

Comments
 (0)