Skip to content

Commit 5bd0ad4

Browse files
authored
Merge pull request Expensify#65236 from dmkt9/fix/64549
2 parents 4697b87 + 262d23b commit 5bd0ad4

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/components/PopoverMenu.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,8 @@ function PopoverMenu({
406406
return styles.createMenuContainer;
407407
}, [isSmallScreenWidth, shouldEnableMaxHeight, windowHeight, styles.createMenuContainer]);
408408

409+
const {paddingTop, paddingBottom, paddingVertical, ...restScrollContainerStyle} = (StyleSheet.flatten([styles.pv4, scrollContainerStyle]) as ViewStyle) ?? {};
410+
409411
return (
410412
<PopoverWithMeasuredContent
411413
anchorPosition={anchorPosition}
@@ -431,18 +433,18 @@ function PopoverMenu({
431433
shouldEnableNewFocusManagement={shouldEnableNewFocusManagement}
432434
useNativeDriver
433435
restoreFocusType={restoreFocusType}
434-
innerContainerStyle={innerContainerStyle}
436+
innerContainerStyle={{...styles.pv0, ...innerContainerStyle}}
435437
shouldUseModalPaddingStyle={shouldUseModalPaddingStyle}
436438
testID={testID}
437439
>
438440
<FocusTrapForModal active={isVisible}>
439441
<View
440442
onLayout={onLayout}
441-
style={[menuContainerStyle, containerStyles]}
443+
style={[menuContainerStyle, containerStyles, {paddingTop, paddingBottom, paddingVertical, ...(isWebOrDesktop ? styles.flex1 : styles.flexGrow1)}]}
442444
>
443445
{renderHeaderText()}
444446
{enteredSubMenuIndexes.length > 0 && renderBackButtonItem()}
445-
{renderWithConditionalWrapper(shouldUseScrollView, scrollContainerStyle, renderedMenuItems)}
447+
{renderWithConditionalWrapper(shouldUseScrollView, restScrollContainerStyle, renderedMenuItems)}
446448
</View>
447449
</FocusTrapForModal>
448450
</PopoverWithMeasuredContent>

src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ function SearchTypeMenuPopover({queryJSON}: SearchTypeMenuNarrowProps) {
3939
shouldUseModalPaddingStyle={false}
4040
innerContainerStyle={{paddingBottom: unmodifiedPaddings.bottom}}
4141
shouldAvoidSafariException
42+
scrollContainerStyle={styles.pv0}
4243
/>
4344
)}
4445
<DeleteConfirmModal />

0 commit comments

Comments
 (0)