Merge pull request Expensify#86956 from callstack-internal/fix/lhn-remove-duplicate-onyx-sub

[No QA] fix: Remove duplicate useOnyx subscription and redundant hook call in LHN

Author: JS00001

src/components/LHNOptionsList/OptionRowLHNData.tsx

@@ -118,7 +118,6 @@ function OptionRowLHNData({
     const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID);
     const {login} = useCurrentUserPersonalDetails();
     const [policyTags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fullReport?.policyID}`);
-    const [fullReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fullReport?.reportID}`);
 
     const card = useGetExpensifyCardFromReportAction({reportAction: lastAction, policyID: fullReport?.policyID});
 
@@ -157,7 +156,7 @@ function OptionRowLHNData({
         reportAttributesDerived,
         policyTags,
         currentUserLogin: login ?? '',
-        reportActions: fullReportActions,
+        reportActions,
     });
 
     // For single-sender IOUs, trim to the sender's avatar to match the header.

src/pages/inbox/sidebar/SidebarLinks.tsx

@@ -5,7 +5,6 @@ import type {EdgeInsets} from 'react-native-safe-area-context';
 import type {ValueOf} from 'type-fest';
 import LHNOptionsList from '@components/LHNOptionsList/LHNOptionsList';
 import OptionsListSkeletonView from '@components/OptionsListSkeletonView';
-import useConfirmReadyToOpenApp from '@hooks/useConfirmReadyToOpenApp';
 import useOnyx from '@hooks/useOnyx';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
 import useStyleUtils from '@hooks/useStyleUtils';
@@ -41,8 +40,6 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
     const {shouldUseNarrowLayout} = useResponsiveLayout();
     const [isLoadingReportData = true] = useOnyx(ONYXKEYS.IS_LOADING_REPORT_DATA);
 
-    useConfirmReadyToOpenApp();
-
     useEffect(() => {
         ReportActionContextMenu.hideContextMenu(false);
         // eslint-disable-next-line react-hooks/exhaustive-deps
@@ -100,7 +97,7 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
                     onFirstItemRendered={setSidebarLoaded}
                 />
                 {isLoadingReportData && optionListItems?.length === 0 && (
-                    <View style={[StyleSheet.absoluteFillObject, styles.appBG, styles.mt3]}>
+                    <View style={[StyleSheet.absoluteFill, styles.appBG, styles.mt3]}>
                         <OptionsListSkeletonView
                             shouldAnimate
                             reasonAttributes={sidebarSkeletonReasonAttributes}