Commit 5e15a63
committed
Normalize iouComment to markdown before rendering
The description field of a saved transaction is stored as HTML
(e.g. <a href="https://google.com">google.com</a>), but
MoneyRequestConfirmationListFooter feeds it into a MenuItemWithTopDescription
with shouldParseTitle, which runs ExpensiMark markdown-to-HTML on the value.
When the input is already HTML, ExpensiMark HTML-escapes the <a> tags, so
the user sees raw <a href=...>google.com</a> text on the Split details page.
Prior to the 'remove redundant props' refactor, SplitBillDetailsPage
normalized the stored HTML with Parser.htmlToMarkdown() before passing
iouComment down. That normalization was dropped when iouComment moved to
a single internal derivation in MoneyRequestConfirmationList. Restoring
the htmlToMarkdown call at the producer keeps every downstream consumer
(shouldParseTitle menu item and type='markdown' text input) consistent
for both draft (plain text) and saved (HTML) transactions, and avoids
regressing auto-linking of bare URLs in draft confirmation flows.1 parent 69a3bdc commit 5e15a63
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
291 | 292 | | |
292 | 293 | | |
293 | 294 | | |
294 | | - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
295 | 300 | | |
296 | 301 | | |
297 | 302 | | |
| |||
0 commit comments