Fix duplicated tax rates when duplicating workspace with distance rates

Use the customUnitRateID from API params for the default distance rate
instead of generating random IDs. This ensures the optimistic data
matches what the server creates, preventing rate duplication when
the server response merges into Onyx.

For per diem units, only update customUnitID without touching rates
since no per diem rate ID is sent to the API.

Author: wildan-m

src/libs/PolicyUtils.ts

@@ -49,7 +49,6 @@ import {getCategoryApproverRule} from './CategoryUtils';
 import {convertToBackendAmount} from './CurrencyUtils';
 import Navigation from './Navigation/Navigation';
 import {getIsOffline} from './NetworkState';
-import {generateHexadecimalValue} from './NumberUtils';
 import {formatMemberForList} from './OptionsListUtils';
 import type {MemberForList} from './OptionsListUtils';
 import {getAccountIDsByLogins, getLoginByAccountID, getLoginsByAccountIDs, getPersonalDetailByEmail} from './PersonalDetailsUtils';
@@ -308,19 +307,22 @@ function hasEligibleActiveAdminFromWorkspaces(policies: OnyxCollection<Policy> |
     return false;
 }
 
-function cloneCustomUnitWithNewIDs(unit: CustomUnit, newCustomUnitID: string): CustomUnit {
-    const newRates: Record<string, Rate> = {};
-    for (const rate of Object.values(unit.rates)) {
-        const newRateID = generateHexadecimalValue(13);
-        newRates[newRateID] = {
-            ...rate,
-            customUnitRateID: newRateID,
+function cloneCustomUnitWithNewIDs(unit: CustomUnit, newCustomUnitID: string, newDefaultRateID?: string): CustomUnit {
+    if (newDefaultRateID) {
+        // For distance units: use the provided rate ID for the default rate,
+        // matching the customUnitRateID sent to the DUPLICATE_POLICY API
+        const defaultRate = Object.values(unit.rates).find((rate) => rate.enabled) ?? Object.values(unit.rates).at(0);
+        return {
+            ...unit,
+            customUnitID: newCustomUnitID,
+            rates: defaultRate ? {[newDefaultRateID]: {...defaultRate, customUnitRateID: newDefaultRateID}} : {},
         };
     }
+
+    // For other units (per diem): only update the customUnitID
     return {
         ...unit,
         customUnitID: newCustomUnitID,
-        rates: newRates,
     };
 }
 
@@ -331,10 +333,11 @@ function getCustomUnitsForDuplication(
     customUnitIDs: {
         distanceCustomUnitID: string;
         perDiemCustomUnitID: string;
+        customUnitRateID: string;
     },
 ): Record<string, CustomUnit> | undefined {
     const customUnits = policy?.customUnits;
-    const {distanceCustomUnitID, perDiemCustomUnitID} = customUnitIDs ?? {};
+    const {distanceCustomUnitID, perDiemCustomUnitID, customUnitRateID} = customUnitIDs ?? {};
 
     if ((!isDistanceRatesOptionSelected && !isPerDiemOptionSelected) || !customUnits || Object.keys(customUnits).length === 0) {
         return undefined;
@@ -349,7 +352,7 @@ function getCustomUnitsForDuplication(
         }
 
         return {
-            [distanceCustomUnitID]: cloneCustomUnitWithNewIDs(distanceCustomUnit, distanceCustomUnitID),
+            [distanceCustomUnitID]: cloneCustomUnitWithNewIDs(distanceCustomUnit, distanceCustomUnitID, customUnitRateID),
             [perDiemCustomUnitID]: cloneCustomUnitWithNewIDs(perDiemUnit, perDiemCustomUnitID),
         };
     }
@@ -359,7 +362,7 @@ function getCustomUnitsForDuplication(
         if (!distanceCustomUnit) {
             return undefined;
         }
-        return {[distanceCustomUnitID]: cloneCustomUnitWithNewIDs(distanceCustomUnit, distanceCustomUnitID)};
+        return {[distanceCustomUnitID]: cloneCustomUnitWithNewIDs(distanceCustomUnit, distanceCustomUnitID, customUnitRateID)};
     }
 
     const perDiemUnit = Object.values(customUnits).find((customUnit) => customUnit.name === CONST.CUSTOM_UNITS.NAME_PER_DIEM_INTERNATIONAL);

src/libs/actions/Policy/Policy.ts

@@ -3198,7 +3198,7 @@ function buildDuplicatePolicyData(policy: Policy, options: DuplicatePolicyDataOp
                 name: policyName,
                 fieldList: isReportsOptionSelected ? policy?.fieldList : undefined,
                 connections: isConnectionsOptionSelected ? policy?.connections : undefined,
-                customUnits: getCustomUnitsForDuplication(policy, isDistanceRatesOptionSelected, isPerDiemOptionSelected, {distanceCustomUnitID, perDiemCustomUnitID}),
+                customUnits: getCustomUnitsForDuplication(policy, isDistanceRatesOptionSelected, isPerDiemOptionSelected, {distanceCustomUnitID, perDiemCustomUnitID, customUnitRateID}),
                 taxRates: isTaxesOptionSelected ? policy?.taxRates : undefined,
                 rules: isCodingRulesOptionSelected ? {codingRules: policy?.rules?.codingRules} : undefined,
                 pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,