Skip to content

Commit 5fd005c

Browse files
MelvinBotdaledah
andcommitted
Use hasAccountingConnections instead of getValidConnectedIntegration for category button visibility
The "Add category" button in the expense category picker was using getValidConnectedIntegration which excludes unverified (failed) connections, while the Categories settings page uses hasAccountingConnections which detects any connection regardless of sync status. This aligns both checks so the button is consistently hidden when an accounting connection exists but has failed. Co-authored-by: daledah <daledah@users.noreply.github.com>
1 parent e6ac2ed commit 5fd005c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {isCategoryMissing} from '@libs/CategoryUtils';
3030
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
3131
import Navigation from '@libs/Navigation/Navigation';
3232
import {hasEnabledOptions} from '@libs/OptionsListUtils';
33-
import {getValidConnectedIntegration, isPolicyAdmin} from '@libs/PolicyUtils';
33+
import {hasAccountingConnections, isPolicyAdmin} from '@libs/PolicyUtils';
3434
import {getTransactionDetails, isGroupPolicy, isReportInGroupPolicy} from '@libs/ReportUtils';
3535
import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
3636
import {getRequestType} from '@libs/TransactionUtils';
@@ -92,7 +92,7 @@ function IOURequestStepCategory({
9292

9393
const categoryForDisplay = isCategoryMissing(transactionCategory) ? '' : transactionCategory;
9494

95-
const canCreateCategoryInSitu = isPolicyAdmin(policy) && !getValidConnectedIntegration(policy) && !!policy?.areCategoriesEnabled;
95+
const canCreateCategoryInSitu = isPolicyAdmin(policy) && !hasAccountingConnections(policy) && !!policy?.areCategoriesEnabled;
9696

9797
const createCategoryMenuItems = canCreateCategoryInSitu
9898
? [

0 commit comments

Comments
 (0)