Merge pull request Expensify#67604 from ikevin127/kevin127-devHeapFollowUp

[NoQA] `webpack-dev-server` GC Plugin & Script Follow-Up

Author: roryabraham

config/webpack/ForceGarbageCollectionPlugin.ts

@@ -15,18 +15,15 @@ class ForceGarbageCollectionPlugin {
             compiler.hooks.done.tap(this.constructor.name, () => {
                 this.compilationCount++;
 
-                // Log memory usage every compilation
                 const memUsage = process.memoryUsage();
                 const heapUsedMB = Math.round(memUsage.heapUsed / 1024 / 1024);
                 const heapTotalMB = Math.round(memUsage.heapTotal / 1024 / 1024);
 
                 console.log(`📊 Compilation #${this.compilationCount} - Heap: ${heapUsedMB}MB/${heapTotalMB}MB`);
                 if (this.compilationCount % 5 === 0) {
                     console.log(`🗑️ Forcing garbage collection after ${this.compilationCount} compilations`);
-                    // @ts-expect-error - gc is a global function provided when Node.js is started with --expose-gc flag
-                    gc();
+                    gc?.();
 
-                    // Log memory after garbage collection
                     const memAfterGC = process.memoryUsage();
                     const heapAfterMB = Math.round(memAfterGC.heapUsed / 1024 / 1024);
                     console.log(`✅ Post-GC heap size: ${heapAfterMB}MB (freed ${heapUsedMB - heapAfterMB}MB)`);

scripts/start-dev-with-auto-restart.sh

@@ -4,25 +4,25 @@
 # This script monitors for heap out of memory errors and automatically restarts
 # Usage: ./start-dev-with-auto-restart.sh [webpack-dev-server arguments]
 
-WDS_ARGS=("$@")
+WEBPACK_DEV_SERVER_ARGS=("$@")
+readonly RESTART_DELAY=1
 MAX_RESTARTS=10
 RESTART_COUNT=0
-RESTART_DELAY=1
 
 echo "🚀 Starting webpack-dev-server with auto-restart (max restarts: $MAX_RESTARTS)"
 
 run_wds () {
     # Check if platform is Desktop to determine open behavior
-    if [[ "${WDS_ARGS[*]}" == *"--env platform=desktop"* ]]; then
+    if [[ "${WEBPACK_DEV_SERVER_ARGS[*]}" == *"--env platform=desktop"* ]]; then
         # For Desktop, always use --no-open since app is handled by Electron
-        node --expose-gc --max-old-space-size=1100 ./node_modules/.bin/webpack-dev-server --no-open "${WDS_ARGS[@]}" --config config/webpack/webpack.dev.ts
+        node --expose-gc ./node_modules/.bin/webpack-dev-server --no-open "${WEBPACK_DEV_SERVER_ARGS[@]}" --config config/webpack/webpack.dev.ts
     else
         # For Web, use the provided open flag
-        node --expose-gc ./node_modules/.bin/webpack-dev-server "$1" "${WDS_ARGS[@]}" --config config/webpack/webpack.dev.ts
+        node --expose-gc ./node_modules/.bin/webpack-dev-server "$1" "${WEBPACK_DEV_SERVER_ARGS[@]}" --config config/webpack/webpack.dev.ts
     fi
 }
 
-while [ $RESTART_COUNT -lt $MAX_RESTARTS ]; do
+while [[ $RESTART_COUNT -lt $MAX_RESTARTS ]]; do
     echo "📊 Attempt #$((RESTART_COUNT + 1)) - Starting webpack-dev-server..."
 
     if [ $RESTART_COUNT -eq 0 ]; then