Commit 60ec693
Defer proactive navigation check to avoid extra renders in perf tests
The navigateToMigratedUserWelcomeModalIfReady() calls were running
synchronously inside Onyx connectWithoutView callbacks, which interfered
with Onyx batch processing and caused an extra render cycle in
SidebarLinks perf tests. Deferring the check to the next event loop tick
via setTimeout(0) with debouncing ensures it doesn't affect the current
batch while still navigating promptly when conditions are met.
Co-authored-by: Eric Han <eh2077@users.noreply.github.com>1 parent af6c6c8 commit 60ec693
1 file changed
Lines changed: 19 additions & 2 deletions
File tree
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
28 | 45 | | |
29 | 46 | | |
30 | 47 | | |
| |||
53 | 70 | | |
54 | 71 | | |
55 | 72 | | |
56 | | - | |
| 73 | + | |
57 | 74 | | |
58 | 75 | | |
59 | 76 | | |
60 | 77 | | |
61 | 78 | | |
62 | 79 | | |
63 | 80 | | |
64 | | - | |
| 81 | + | |
65 | 82 | | |
66 | 83 | | |
67 | 84 | | |
| |||
0 commit comments