fixed PR comments and added changes for reports page and workspaceInitialPage

Author: Burhan-Rashid

src/components/MenuItem.tsx

@@ -420,9 +420,6 @@ type MenuItemBaseProps = ForwardedFSClassProps &
         /** Whether the screen containing the item is focused */
         isFocused?: boolean;
 
-        /** Whether the item is selected */
-        selected?: boolean;
-
         /** Additional styles for the root wrapper View */
         rootWrapperStyle?: StyleProp<ViewStyle>;
 
@@ -579,7 +576,6 @@ function MenuItem({
     forwardedFSClass,
     ref,
     isFocused,
-    selected,
     sentryLabel,
     rootWrapperStyle,
     role = CONST.ROLE.BUTTON,
@@ -801,7 +797,7 @@ function MenuItem({
                                 role={interactive ? role : undefined}
                                 accessibilityLabel={`${enhancedAccessibilityLabel}${brickRoadIndicator ? `. ${translate('common.yourReviewIsRequired')}` : ''}`}
                                 accessible={shouldBeAccessible}
-                                accessibilityState={{selected}}
+                                accessibilityState={role === CONST.ROLE.TAB ? {selected: focused} : undefined}
                                 tabIndex={interactive ? tabIndex : -1}
                                 onFocus={onFocus}
                                 sentryLabel={sentryLabel}

src/pages/Search/SearchTypeMenuItem.tsx

@@ -41,7 +41,8 @@ function SearchTypeMenuItem({title, icon, badgeText, focused = false, onPress}:
         <PressableWithoutFeedback
             onPress={onPress}
             accessibilityLabel={title}
-            role={CONST.ROLE.BUTTON}
+            accessibilityState={{selected: focused}}
+            role={CONST.ROLE.TAB}
             sentryLabel={CONST.SENTRY_LABEL.SEARCH.TYPE_MENU_ITEM}
             style={({hovered, pressed}) => [
                 styles.flexRow,

src/pages/settings/InitialSettingsPage.tsx

@@ -470,7 +470,6 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr
                             shouldBlockSelection={!!item.link}
                             onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined}
                             focused={isFocused}
-                            selected={isFocused}
                             role={CONST.ROLE.TAB}
                             isPaneMenu
                             sentryLabel={item.sentryLabel}

src/pages/workspace/WorkspaceInitialPage.tsx

@@ -478,6 +478,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac
                                     wrapperStyle={styles.sectionMenuItem(shouldUseNarrowLayout)}
                                     highlighted={!!item?.highlighted}
                                     focused={!!(item.screenName && activeRoute?.startsWith(item.screenName))}
+                                    role={CONST.ROLE.TAB}
                                     badgeText={item.badgeText}
                                     shouldIconUseAutoWidthStyle
                                     sentryLabel={item.sentryLabel}