Merge pull request Expensify#63103 from callstack-internal/pac-guerreiro/issue/62882-change-function-to-be-pure-where-taskReport-is-passed-as-a-parameter

Refactor completeTestDriveTask() to be pure

Author: marcaaron

src/components/TestDrive/TestDriveDemo.tsx

@@ -24,12 +24,19 @@ function TestDriveDemo() {
     const styles = useThemeStyles();
     const [onboarding] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {canBeMissing: false});
     const [onboardingReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${onboarding?.chatReportID}`, {canBeMissing: true});
+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: false});
+    const viewTourReportID = introSelected?.viewTour;
+    const [viewTourReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourReportID}`, {canBeMissing: true});
 
     useEffect(() => {
         InteractionManager.runAfterInteractions(() => {
             setIsVisible(true);
-            completeTestDriveTask();
+            completeTestDriveTask(viewTourReport, viewTourReportID);
         });
+
+        // This should fire only during mount.
+        // eslint-disable-next-line react-compiler/react-compiler
+        // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
     const closeModal = useCallback(() => {

src/libs/actions/Task.ts

@@ -1318,11 +1318,9 @@ function getFinishOnboardingTaskOnyxData(taskName: IntroSelectedTask): OnyxData
 
     return {};
 }
-function completeTestDriveTask(shouldUpdateSelfTourViewedOnlyLocally = false) {
-    const taskReportID = introSelected?.viewTour;
-    const taskReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`];
+function completeTestDriveTask(viewTourReport: OnyxEntry<OnyxTypes.Report>, viewTourReportID: string | undefined, shouldUpdateSelfTourViewedOnlyLocally = false) {
     setSelfTourViewed(shouldUpdateSelfTourViewedOnlyLocally);
-    completeTask(taskReport, taskReportID);
+    completeTask(viewTourReport, viewTourReportID);
 }
 
 export {

src/pages/Search/EmptySearchView.tsx

@@ -165,6 +165,8 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
         selector: hasSeenTourSelector,
         canBeMissing: true,
     });
+    const viewTourReportID = introSelected?.viewTour;
+    const [viewTourReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourReportID}`, {canBeMissing: true});
 
     const content: EmptySearchViewItem = useMemo(() => {
         // Begin by going through all of our To-do searches, and returning their empty state
@@ -190,7 +192,7 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
         const startTestDrive = () => {
             InteractionManager.runAfterInteractions(() => {
                 if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
-                    completeTestDriveTask();
+                    completeTestDriveTask(viewTourReport, viewTourReportID);
                     Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
                 } else {
                     Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
@@ -368,6 +370,8 @@ function EmptySearchView({hash, type, groupBy, hasResults}: EmptySearchViewProps
         tripViewChildren,
         hasResults,
         shouldRedirectToExpensifyClassic,
+        viewTourReport,
+        viewTourReportID,
     ]);
 
     return (

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

@@ -131,6 +131,8 @@ function FloatingActionButtonAndPopover({onHideCreateMenu, onShowCreateMenu, isT
         selector: hasSeenTourSelector,
         canBeMissing: true,
     });
+    const viewTourReportID = introSelected?.viewTour;
+    const [viewTourReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourReportID}`, {canBeMissing: true});
 
     const {setRootStatusBarEnabled} = useContext(CustomStatusBarAndBackgroundContext);
 
@@ -489,7 +491,7 @@ function FloatingActionButtonAndPopover({onHideCreateMenu, onShowCreateMenu, isT
                       onSelected: () => {
                           InteractionManager.runAfterInteractions(() => {
                               if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
-                                  completeTestDriveTask(isAnonymousUser());
+                                  completeTestDriveTask(viewTourReport, viewTourReportID, isAnonymousUser());
                                   Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
                               } else {
                                   Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

@@ -185,6 +185,10 @@ function IOURequestStepConfirmation({
     // TODO: remove beta check after the feature is enabled
     const {isBetaEnabled} = usePermissions();
 
+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: false});
+    const viewTourReportID = introSelected?.viewTour;
+    const [viewTourReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${viewTourReportID}`, {canBeMissing: true});
+
     const headerTitle = useMemo(() => {
         if (isCategorizingTrackExpense) {
             return translate('iou.categorize');
@@ -478,7 +482,7 @@ function IOURequestStepConfirmation({
                 const isTestDriveReceipt = receipt?.isTestDriveReceipt ?? false;
 
                 if (isTestDriveReceipt) {
-                    completeTestDriveTask();
+                    completeTestDriveTask(viewTourReport, viewTourReportID);
                 }
 
                 requestMoneyIOUActions({
@@ -534,6 +538,8 @@ function IOURequestStepConfirmation({
             transactionTaxAmount,
             customUnitRateID,
             backToReport,
+            viewTourReport,
+            viewTourReportID,
         ],
     );
 

tests/actions/TaskTest.ts

@@ -224,7 +224,7 @@ describe('actions/Task', () => {
         it('Completes test drive task', () => {
             const writeSpy = jest.spyOn(API, 'write');
 
-            completeTestDriveTask();
+            completeTestDriveTask(testDriveTaskReport, testDriveTaskReport.reportID);
 
             expect(writeSpy).toHaveBeenCalledWith(WRITE_COMMANDS.COMPLETE_TASK, expect.anything(), expect.anything());
         });