Revert max-warnings change and add explanatory comments to eslint-disable directives

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

Author: MelvinBot

package.json

@@ -45,7 +45,7 @@
     "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
     "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
     "typecheck-tsgo": "tsgo --project tsconfig.tsgo.json",
-    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=331 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=334 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
     "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
     "check-lazy-loading": "ts-node scripts/checkLazyLoading.ts",
     "lint-watch": "npx eslint-watch --watch --changed",

src/pages/workspace/travel/WorkspaceTravelInvoicingExportPage.tsx

@@ -181,6 +181,8 @@ function WorkspaceTravelInvoicingExportPage({route}: WorkspaceTravelInvoicingExp
                 setIsDownloading(false),
             );
         } else {
+            // Intentional: this setState resets the loading indicator when generation completes but no file is available.
+            // It runs in a cleanup path of the effect, not as a cascading re-render trigger.
             // eslint-disable-next-line react-hooks/set-state-in-effect
             setIsDownloading(false);
         }

src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

@@ -87,6 +87,8 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) {
 
     const defaultApprover = getDefaultApprover(policy);
 
+    // useCallback is needed here because goBack is passed as a prop to child components;
+    // the rule flags it because the deps could be inlined, but removing useCallback would cause unnecessary re-renders.
     // eslint-disable-next-line react-hooks/preserve-manual-memoization
     const goBack = useCallback(() => {
         if ((!feature && featureNameAlias !== CONST.UPGRADE_FEATURE_INTRO_MAPPING.policyPreventMemberChangingTitle.alias) || !policyID) {
@@ -132,6 +134,8 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) {
         upgradeToCorporate(policy.id, feature?.name);
     };
 
+    // useCallback is needed here because confirmUpgrade is passed as a prop to child components;
+    // the rule flags it because the deps could be inlined, but removing useCallback would cause unnecessary re-renders.
     // eslint-disable-next-line react-hooks/preserve-manual-memoization
     const confirmUpgrade = useCallback(() => {
         if (!policyID) {

src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx

@@ -123,6 +123,8 @@ function WorkspaceWorkflowsApprovalsEditPage({policy, isLoadingReportData = true
             errors: null,
             originalApprovers: currentApprovalWorkflow.approvers,
         });
+        // Intentional: synchronizes the initial workflow snapshot when the current workflow changes.
+        // This runs alongside setApprovalWorkflow above and is part of the same logical update.
         // eslint-disable-next-line react-hooks/set-state-in-effect
         setInitialApprovalWorkflow(currentApprovalWorkflow);
     }, [currentApprovalWorkflow, defaultWorkflowMembers, initialApprovalWorkflow, usedApproverEmails]);

src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

@@ -48,6 +48,8 @@ function WorkspaceWorkflowsApprovalsExpensesFromPage({policy, isLoadingReportDat
             return;
         }
 
+        // Intentional: derives the selected-members list from the approval workflow data.
+        // This effect synchronizes local component state with the Onyx-sourced workflow when it changes.
         // eslint-disable-next-line react-hooks/set-state-in-effect
         setSelectedMembers(
             approvalWorkflow.members.map((member) => {