Merge branch 'main' into paulnjs-fix/88315-part-2

Author: paulnjs

.github/ISSUE_TEMPLATE/Accessibility.md

@@ -4,7 +4,7 @@ about: A template to follow when creating a new issue for accessibility failures
 labels: ["Accessibility", "Weekly"]
 ---
 
-If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel!
+If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding. To join our Slack channel, fill out [this form](https://forms.gle/Q7hnhUJPnQCK7Fe56). 
 ___
 
 ## Action Performed:

.github/ISSUE_TEMPLATE/Exploratory.md

@@ -4,7 +4,7 @@ about: A template to follow when creating a new issue in this repository that wa
 labels: Monthly, Not a priority
 ---
 
-If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel!
+If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding. To join our Slack channel, fill out [this form](https://forms.gle/Q7hnhUJPnQCK7Fe56). 
 ___
 **For all Exploratory issues, start the title of the issue with `[Exploratory]`** (and, do **not** add the `External` label.
 

.github/ISSUE_TEMPLATE/Performance.md

@@ -5,7 +5,7 @@ title: "[Performance] "
 labels: Engineering, Daily
 ---
 
-If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel!
+If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding. To join our Slack channel, fill out [this form](https://forms.gle/Q7hnhUJPnQCK7Fe56).
 ___
 
 ## What performance issue do we need to solve?

.github/ISSUE_TEMPLATE/Standard.md

@@ -4,7 +4,7 @@ about: A standard template to follow when creating a new issue in this repositor
 labels: Bug, Daily
 ---
 
-If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel!
+If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding. To join our Slack channel, fill out [this form](https://forms.gle/Q7hnhUJPnQCK7Fe56).
 ___
 
 **Version Number:**

.github/actions/composite/announceFailedWorkflowInSlack/action.yml

@@ -13,20 +13,17 @@ inputs:
 runs:
   using: composite
   steps:
-    - uses: 8398a7/action-slack@1750b5085f3ec60384090fb7c52965ef822e869e
+    - uses: slackapi/slack-github-action@45a88b9581bfab2566dc881e2cd66d334e621e2c # v3.0.3
       name: Job failed Slack notification
       with:
-        status: custom
-        fields: workflow, repo
-        custom_payload: |
+        webhook: ${{ inputs.SLACK_WEBHOOK }}
+        webhook-type: incoming-webhook
+        payload: |
           {
-            channel: '${{ inputs.CHANNEL }}',
-            attachments: [{
-              color: "#DB4545",
-              pretext: `<!subteam^S4TJJ3PSL>`,
-              text: `💥 ${process.env.AS_REPO} failed on <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> workflow 💥`,
+            "channel": "${{ inputs.CHANNEL }}",
+            "attachments": [{
+              "color": "#DB4545",
+              "pretext": "<!subteam^S4TJJ3PSL>",
+              "text": "💥 ${{ github.repository }} failed on <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> workflow 💥"
             }]
           }
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-        SLACK_WEBHOOK_URL: ${{ inputs.SLACK_WEBHOOK }}

.github/scripts/createDocsRoutes.ts

@@ -45,15 +45,22 @@ const platformNames = {
     travel: 'travel',
 } as const;
 
+// Words that should be fully uppercased in auto-generated titles (e.g. "ai" -> "AI")
+const ACRONYMS = new Set(['ai']);
+
 /**
  * @param str - The string to convert to title case
  */
 function toTitleCase(str: string): string {
     return str
         .split(' ')
         .map((word, index) => {
-            if (index !== 0 && (word.toLowerCase() === 'a' || word.toLowerCase() === 'the' || word.toLowerCase() === 'and')) {
-                return word.toLowerCase();
+            const lowerWord = word.toLowerCase();
+            if (ACRONYMS.has(lowerWord)) {
+                return word.toUpperCase();
+            }
+            if (index !== 0 && (lowerWord === 'a' || lowerWord === 'the' || lowerWord === 'and')) {
+                return lowerWord;
             }
             return word.charAt(0).toUpperCase() + word.substring(1);
         })
@@ -128,6 +135,10 @@ function buildSection(platformName: string, hub: string, sectionPath: string, pa
         }
     }
 
+    // Articles are displayed in the order stored here, so sort by the optional `order` front matter.
+    // The sort is stable, so articles without an `order` keep their relative position and fall after ordered ones.
+    articles.sort((a, b) => (a.order ?? Number.POSITIVE_INFINITY) - (b.order ?? Number.POSITIVE_INFINITY));
+
     const section: Section = {
         href,
         title: toTitleCase(sectionName.replaceAll('-', ' ')),

.github/workflows/androidBump.yml

@@ -16,8 +16,8 @@ jobs:
         uses: ./.github/actions/composite/setupNode
 
       - name: Setup Ruby
-        # v1.229.0
-        uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252
+        # v1.310.0
+        uses: ruby/setup-ruby@afeafc3d1ab54a631816aba4c914a0081c12ff2f
         with:
           bundler-cache: true
 
@@ -52,19 +52,16 @@ jobs:
 
       - name: Warn deployers if Android rollout percentage could not be updated
         if: ${{ failure() }}
-        # v3
-        uses: 8398a7/action-slack@1750b5085f3ec60384090fb7c52965ef822e869e
+        uses: slackapi/slack-github-action@45a88b9581bfab2566dc881e2cd66d334e621e2c # v3.0.3
         with:
-          status: custom
-          custom_payload: |
+          webhook: ${{ secrets.SLACK_WEBHOOK }}
+          webhook-type: incoming-webhook
+          payload: |
             {
-              channel: '#deployer',
-              attachments: [{
-                color: "#DB4545",
-                pretext: `<!subteam^S4TJJ3PSL>`,
-                text: `💥 Android rollout percentage could not be updated. <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Run> 💥`,
+              "channel": "#deployer",
+              "attachments": [{
+                "color": "#DB4545",
+                "pretext": "<!subteam^S4TJJ3PSL>",
+                "text": "💥 Android rollout percentage could not be updated. <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View Run> 💥"
               }]
             }
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}

.github/workflows/buildAndroid.yml

@@ -116,8 +116,8 @@ jobs:
         uses: ./.github/actions/composite/getJavaVersion
 
       - name: Setup Java
-        # v4
-        uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
+        # v5
+        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
         with:
           distribution: oracle
           java-version: ${{ steps.get-java-version.outputs.version }}
@@ -142,8 +142,8 @@ jobs:
 
       - name: Load Android upload keystore credentials from 1Password
         id: load-credentials
-        # v3
-        uses: 1password/load-secrets-action@8d0d610af187e78a2772c2d18d627f4c52d3fbfb
+        # v4.0.0
+        uses: 1password/load-secrets-action@92467eb28f72e8255933372f1e0707c567ce2259
         with:
           export-env: false
         env:

.github/workflows/buildIOS.yml

@@ -104,8 +104,8 @@ jobs:
         run: ./.github/scripts/inject-ci-data.sh PULL_REQUEST_NUMBER="$PULL_REQUEST_NUMBER"
 
       - name: Setup Ruby
-        # v1.229.0
-        uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252
+        # v1.310.0
+        uses: ruby/setup-ruby@afeafc3d1ab54a631816aba4c914a0081c12ff2f
         with:
           bundler-cache: true
 

.github/workflows/buildVictoryChartRenderer.yml

@@ -0,0 +1,75 @@
+name: Build victory-chart-renderer
+
+on:
+  workflow_call:
+    inputs:
+      ref:
+        description: Git ref to checkout and build
+        type: string
+        required: true
+      release-tag:
+        description: GitHub Release tag for this deploy (used in failure notifications)
+        type: string
+        required: true
+
+    outputs:
+      BINARY_FILENAME:
+        description: Filename of the compiled Linux x64 binary
+        value: ${{ jobs.build.outputs.BINARY_FILENAME }}
+
+jobs:
+  build:
+    name: Build victory-chart-renderer (Linux x64)
+    runs-on: blacksmith-8vcpu-ubuntu-2404
+    outputs:
+      BINARY_FILENAME: victory-chart-renderer-linux-x64
+    steps:
+      - name: Checkout
+        uses: useblacksmith/checkout@c9796daa2a4bdebdab5bd16be2c09a70cd4e1121 # v1
+        with:
+          ref: ${{ inputs.ref }}
+
+      - name: Setup Node
+        uses: ./.github/actions/composite/setupNode
+
+      - name: Setup Bun
+        # v2.2.0
+        uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6
+        with:
+          bun-version-file: .bun-version
+
+      - name: Build victory-chart-renderer Linux x64 binary
+        run: npm run server:vcr:build:linux
+
+      - name: Verify compiled binary is executable
+        run: test -x server/victory-chart-renderer/dist/victory-chart-renderer-linux-x64
+
+      - name: Upload victory-chart-renderer Linux x64 artifact
+        # v6
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
+        with:
+          name: victory-chart-renderer-linux-x64-artifact
+          path: server/victory-chart-renderer/dist/victory-chart-renderer-linux-x64
+
+      - name: Log victory-chart-renderer build failure
+        if: failure() || cancelled()
+        run: |
+          echo "::error::victory-chart-renderer Linux x64 build did not succeed for release ${{ inputs.release-tag }}. GitHub Release will not include victory-chart-renderer-linux-x64."
+
+      - name: Announce victory-chart-renderer build failure in Slack
+        if: failure() || cancelled()
+        # v3
+        uses: 8398a7/action-slack@1750b5085f3ec60384090fb7c52965ef822e869e
+        with:
+          status: custom
+          custom_payload: |
+            {
+              channel: '#announce',
+              attachments: [{
+                color: 'warning',
+                text: `⚠️ ${process.env.AS_REPO} <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|victory-chart-renderer build> failed for deploy release <https://github.com/Expensify/App/releases/tag/${{ inputs.release-tag }}|${{ inputs.release-tag }}>. victory-chart-renderer-linux-x64 will not be attached.`,
+              }]
+            }
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}