Skip to content

Commit 668f59c

Browse files
committed
Fix TS2345: wrap cleanup to return void instead of Promise
useEffect cleanup functions must return void, not Promise<void>. The arrow shorthand was implicitly returning the promise from clearActiveTransactionIDs(). Wrapping in a block body discards it. Made-with: Cursor
1 parent 9cb1ede commit 668f59c

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,9 @@ function MoneyRequestReportTransactionList({
289289
}, [visualOrderTransactionIDs]);
290290

291291
useEffect(() => {
292-
return () => clearActiveTransactionIDs();
292+
return () => {
293+
clearActiveTransactionIDs();
294+
};
293295
}, []);
294296

295297
const sortedTransactionsMap = useMemo(() => {

tests/unit/MoneyRequestReportTransactionListActiveTransactionIDsTest.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ function useActiveTransactionIDsEffect(visualOrderTransactionIDs: string[]) {
3838
}, [visualOrderTransactionIDs]);
3939

4040
useEffect(() => {
41-
return () => clearActiveTransactionIDs();
41+
return () => {
42+
clearActiveTransactionIDs();
43+
};
4244
}, []);
4345
}
4446

0 commit comments

Comments
 (0)