Merge pull request Expensify#87556 from Expensify/claude-fixFlakyPendingConciergeResponseTest

Fix flaky usePendingConciergeResponse unmount test

Author: madmax330

tests/unit/hooks/usePendingConciergeResponse.test.ts

@@ -116,21 +116,27 @@ describe('usePendingConciergeResponse', () => {
     });
 
     it('should cancel the timer on unmount and not apply the action', async () => {
-        // Given a pending concierge response
+        // Given a pending concierge response with a short delay
+        const timerDelay = SHORT_DELAY;
         await Onyx.merge(`${ONYXKEYS.COLLECTION.PENDING_CONCIERGE_RESPONSE}${REPORT_ID}`, {
             reportAction: fakeConciergeAction,
-            displayAfter: Date.now() + SHORT_DELAY,
+            displayAfter: Date.now() + timerDelay,
         });
         await waitForBatchedUpdates();
 
+        // Switch to fake timers so we can advance past the deadline deterministically
+        jest.useFakeTimers();
+
         const {unmount} = renderHook(() => usePendingConciergeResponse(REPORT_ID));
-        await waitForBatchedUpdates();
 
         // When the hook unmounts before the delay
         unmount();
 
-        // And we wait past the delay
-        await delay(SHORT_DELAY + 50);
+        // Advance well past the timer deadline — if clearTimeout were missing, the callback would fire here
+        jest.advanceTimersByTime(timerDelay + 1000);
+
+        // Restore real timers before async assertions
+        jest.useRealTimers();
         await waitForBatchedUpdates();
 
         // Then the action should NOT be in REPORT_ACTIONS (timer was cleaned up)