fix(submit-onboarding): open side panel on every desktop width

Mirror the SidePanelContextProvider convention by passing
`!isSmallScreenWidth` to `SidePanelActions.openSidePanel` from
`navigateToSubmitWorkspaceAfterOnboarding`. The previous hard-coded
`false` only set the wide-screen NVP key, so the panel stayed hidden
in the 800-1300 px desktop range. mWeb still gets `false`, preserving
the earlier fix that prevented the auto-bounce to Concierge.

Author: abzokhattab

src/hooks/useAutoCreateSubmitWorkspace.ts

@@ -17,6 +17,7 @@ import useLocalize from './useLocalize';
 import useOnboardingMessages from './useOnboardingMessages';
 import useOnyx from './useOnyx';
 import usePreferredPolicy from './usePreferredPolicy';
+import useResponsiveLayout from './useResponsiveLayout';
 
 /**
  * Hook that provides a function to auto-create a Submit workspace for EMPLOYER
@@ -50,6 +51,8 @@ function useAutoCreateSubmitWorkspace() {
     const {isRestrictedPolicyCreation} = usePreferredPolicy();
     const hasActiveAdminPolicies = useHasActiveAdminPolicies();
     const {onboardingMessages} = useOnboardingMessages();
+    // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
+    const {isSmallScreenWidth} = useResponsiveLayout();
 
     const autoCreateSubmitWorkspace = useCallback(
         (firstName: string, lastName: string) => {
@@ -93,7 +96,7 @@ function useAutoCreateSubmitWorkspace() {
             setOnboardingAdminsChatReportID();
             setOnboardingPolicyID();
 
-            navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(newPolicyID);
+            navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(newPolicyID, isSmallScreenWidth);
         },
         [
             currentUserEmail,
@@ -112,6 +115,7 @@ function useAutoCreateSubmitWorkspace() {
             onboardingMessages,
             betas,
             hasActiveAdminPolicies,
+            isSmallScreenWidth,
         ],
     );
 

src/libs/navigateAfterOnboarding.ts

@@ -131,7 +131,7 @@ function navigateAfterOnboardingWithMicrotaskQueue(
  * navigate to Workspace > Categories with the side panel open so
  * the #admins room is visible in Concierge Anywhere.
  */
-function navigateToSubmitWorkspaceAfterOnboarding(policyID?: string) {
+function navigateToSubmitWorkspaceAfterOnboarding(policyID?: string, isSmallScreenWidth = false) {
     setDisableDismissOnEscape(false);
 
     if (!policyID) {
@@ -140,21 +140,17 @@ function navigateToSubmitWorkspaceAfterOnboarding(policyID?: string) {
     }
 
     setOnboardingRHPVariant(CONST.ONBOARDING_RHP_VARIANT.RHP_ADMINS_ROOM);
-    // Push the Workspaces list first so the native back stack lands there
-    // after the user finishes exploring their newly created/joined Submit
-    // workspace. The second navigate is queued on the microtask queue so
-    // both calls are processed sequentially rather than batched.
     Navigation.navigate(ROUTES.WORKSPACES_LIST.route);
     Navigation.setNavigationActionToMicrotaskQueue(() => {
         Navigation.navigate(ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID));
-        SidePanelActions.openSidePanel(false);
+        SidePanelActions.openSidePanel(!isSmallScreenWidth);
     });
 }
 
-function navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(policyID?: string) {
+function navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(policyID?: string, isSmallScreenWidth = false) {
     Navigation.dismissModal();
     Navigation.setNavigationActionToMicrotaskQueue(() => {
-        navigateToSubmitWorkspaceAfterOnboarding(policyID);
+        navigateToSubmitWorkspaceAfterOnboarding(policyID, isSmallScreenWidth);
     });
 }
 

src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

@@ -107,7 +107,7 @@ function BaseOnboardingWorkspaces({route, shouldUseNativeStyles}: BaseOnboarding
         setOnboardingPolicyID(policy.policyID);
 
         if (shouldUseSubmitFlow && policy.automaticJoiningEnabled) {
-            navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(policy.policyID);
+            navigateToSubmitWorkspaceAfterOnboardingWithMicrotaskQueue(policy.policyID, isSmallScreenWidth);
             return;
         }
 

tests/unit/hooks/useAutoCreateSubmitWorkspace.test.ts

@@ -161,7 +161,7 @@ describe('useAutoCreateSubmitWorkspace', () => {
         // Then the user should be navigated to the newly created Submit workspace
         // so they land on their workspace immediately after onboarding
         expect(navigateSpy).toHaveBeenCalledTimes(1);
-        expect(navigateSpy).toHaveBeenCalledWith(MOCK_POLICY_ID);
+        expect(navigateSpy).toHaveBeenCalledWith(MOCK_POLICY_ID, expect.any(Boolean));
     });
 
     it('reuses the existing onboarding workspace instead of creating a new one', () => {