Skip to content

Commit 73d51b5

Browse files
DylanDylannclaude
andcommitted
fix: correct consumer imports and test mocks for ReportWorkflow
- Restore missing canIOUBePaid, canApproveIOU, approveMoneyRequest, submitReport imports in consumer files that were incorrectly aliased - Update test mocks to target @libs/actions/IOU/ReportWorkflow - Run prettier on ReportWorkflow.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 149bd49 commit 73d51b5

7 files changed

Lines changed: 9 additions & 16 deletions

File tree

src/components/MoneyReportHeaderPrimaryAction/PayPrimaryAction.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {
2525
} from '@libs/ReportUtils';
2626
import {isExpensifyCardTransaction, isPending} from '@libs/TransactionUtils';
2727
import {payInvoice, payMoneyRequest} from '@userActions/IOU/PayMoneyRequest';
28-
import {canApproveIOU as canIOUBePaidAction} from '@userActions/IOU/ReportWorkflow';
28+
import {canApproveIOU, canIOUBePaid as canIOUBePaidAction} from '@userActions/IOU/ReportWorkflow';
2929
import CONST from '@src/CONST';
3030
import ONYXKEYS from '@src/ONYXKEYS';
3131
import ROUTES from '@src/ROUTES';

src/components/ReportActionItem/MoneyRequestReportPreview/PayActionButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
isInvoiceReport as isInvoiceReportUtils,
2222
} from '@libs/ReportUtils';
2323
import {payInvoice, payMoneyRequest} from '@userActions/IOU/PayMoneyRequest';
24-
import {approveMoneyRequest as canIOUBePaidIOUActions} from '@userActions/IOU/ReportWorkflow';
24+
import {approveMoneyRequest, canIOUBePaid as canIOUBePaidIOUActions} from '@userActions/IOU/ReportWorkflow';
2525
import CONST from '@src/CONST';
2626
import ONYXKEYS from '@src/ONYXKEYS';
2727
import ROUTES from '@src/ROUTES';

src/hooks/useSelectionModeReportActions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type {ActionHandledType} from '@components/ProcessMoneyReportHoldMenu';
1313
import {useSearchActionsContext, useSearchStateContext} from '@components/Search/SearchContext';
1414
import type {PaymentActionParams} from '@components/SettlementButton/types';
1515
import {payInvoice, payMoneyRequest} from '@libs/actions/IOU/PayMoneyRequest';
16-
import {approveMoneyRequest, canApproveIOU, canIOUBePaid as canIOUBePaidAction} from '@libs/actions/IOU/ReportWorkflow';
16+
import {approveMoneyRequest, canApproveIOU, canIOUBePaid as canIOUBePaidAction, submitReport} from '@libs/actions/IOU/ReportWorkflow';
1717
import {turnOffMobileSelectionMode} from '@libs/actions/MobileSelectionMode';
1818
import {search} from '@libs/actions/Search';
1919
import getPlatform from '@libs/getPlatform';

src/libs/actions/IOU/ReportWorkflow.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ import {
5050
allHavePendingRTERViolation,
5151
hasAnyTransactionWithoutRTERViolation,
5252
hasDuplicateTransactions,
53-
isDuplicate,
5453
hasSmartScanFailedWithMissingFields,
5554
hasSubmissionBlockingViolations,
55+
isDuplicate,
5656
isOnHold,
5757
isPending,
5858
isPendingCardOrScanningTransaction,
@@ -64,14 +64,7 @@ import ROUTES from '@src/ROUTES';
6464
import type * as OnyxTypes from '@src/types/onyx';
6565
import type ReportAction from '@src/types/onyx/ReportAction';
6666
import {isEmptyObject} from '@src/types/utils/EmptyObject';
67-
import {
68-
getAllReportActionsFromIOU,
69-
getAllReportNameValuePairs,
70-
getAllTransactionViolations,
71-
getCurrentUserEmail,
72-
getReportFromHoldRequestsOnyxData,
73-
getUserAccountID,
74-
} from '.';
67+
import {getAllReportActionsFromIOU, getAllReportNameValuePairs, getAllTransactionViolations, getCurrentUserEmail, getReportFromHoldRequestsOnyxData, getUserAccountID} from '.';
7568

7669
type ApproveMoneyRequestFunctionParams = {
7770
expenseReport: OnyxEntry<OnyxTypes.Report>;

tests/unit/PaymentUtilsTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jest.mock('@libs/actions/BankAccounts', () => ({
2828
setPersonalBankAccountContinueKYCOnSuccess: jest.fn(),
2929
}));
3030

31-
jest.mock('@libs/actions/IOU', () => ({
31+
jest.mock('@libs/actions/IOU/ReportWorkflow', () => ({
3232
approveMoneyRequest: jest.fn(),
3333
}));
3434

tests/unit/ReportSubmitUtilsTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {createExpenseReport, createPolicyExpenseChat} from '../utils/collections
88
import createRandomTransaction from '../utils/collections/transaction';
99
import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
1010

11-
jest.mock('@libs/actions/IOU', () => ({
11+
jest.mock('@libs/actions/IOU/ReportWorkflow', () => ({
1212
canSubmitReport: jest.fn(),
1313
}));
1414

tests/unit/hooks/useSelectionModeReportActions.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ jest.mock('@libs/ReportUtils', () => {
190190
};
191191
});
192192

193-
jest.mock('@libs/actions/IOU', () => ({
193+
jest.mock('@libs/actions/IOU/ReportWorkflow', () => ({
194194
__esModule: true,
195195
submitReport: jest.fn(),
196196
approveMoneyRequest: jest.fn(),
@@ -258,7 +258,7 @@ const DelegateProvider = require('@components/DelegateNoAccessModalProvider') as
258258
// eslint-disable-next-line @typescript-eslint/no-require-imports
259259
const LockedProvider = require('@components/LockedAccountModalProvider') as Record<string, jest.Mock>;
260260
// eslint-disable-next-line @typescript-eslint/no-require-imports
261-
const IOUActions = require('@libs/actions/IOU') as Record<string, jest.Mock>;
261+
const IOUActions = require('@libs/actions/IOU/ReportWorkflow') as Record<string, jest.Mock>;
262262
const PayMoneyRequestActions = require('@libs/actions/IOU/PayMoneyRequest') as Record<string, jest.Mock>;
263263
// eslint-disable-next-line @typescript-eslint/no-require-imports
264264
const usePaymentOptionsMock = require('@hooks/usePaymentOptions') as {default: jest.Mock};

0 commit comments

Comments
 (0)