Skip to content

Commit 77c5f78

Browse files
MelvinBotmkhutornyi
andcommitted
Use correct cardName translation key for personal card rename flow
The personal card edit name page and card details header menu were using the 'cardNumber' translation key instead of 'cardName', causing the label to show "Card number" instead of "Card name". Co-authored-by: mkhutornyi <mkhutornyi@users.noreply.github.com>
1 parent f094ea5 commit 77c5f78

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/pages/settings/Wallet/PersonalCardDetailsHeaderMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function PersonalCardDetailsHeaderMenu({
8181
}}
8282
>
8383
<MenuItemWithTopDescription
84-
description={translate('workspace.moreFeatures.companyCards.cardNumber')}
84+
description={translate('workspace.moreFeatures.companyCards.cardName')}
8585
title={customCardNames?.[cardID] ?? card?.cardName ?? getDefaultCardName(cardholder?.firstName)}
8686
shouldShowRightIcon
8787
brickRoadIndicator={card?.nameValuePairs?.errorFields?.cardTitle ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}

src/pages/settings/Wallet/PersonalCardEditNamePage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function PersonalCardEditNamePage({route}: PersonalCardEditNamePageProps) {
6969
shouldEnableMaxHeight
7070
>
7171
<HeaderWithBackButton
72-
title={translate('workspace.moreFeatures.companyCards.cardNumber')}
72+
title={translate('workspace.moreFeatures.companyCards.cardName')}
7373
onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_PERSONAL_CARD_DETAILS.getRoute(cardID))}
7474
/>
7575
<Text style={[styles.mh5, styles.mt3, styles.mb5]}>{translate('workspace.moreFeatures.companyCards.giveItNameInstruction')}</Text>
@@ -85,8 +85,8 @@ function PersonalCardEditNamePage({route}: PersonalCardEditNamePageProps) {
8585
<InputWrapper
8686
InputComponent={TextInput}
8787
inputID={INPUT_IDS.NAME}
88-
label={translate('workspace.moreFeatures.companyCards.cardNumber')}
89-
aria-label={translate('workspace.moreFeatures.companyCards.cardNumber')}
88+
label={translate('workspace.moreFeatures.companyCards.cardName')}
89+
aria-label={translate('workspace.moreFeatures.companyCards.cardName')}
9090
role={CONST.ROLE.PRESENTATION}
9191
defaultValue={defaultValue}
9292
ref={inputCallbackRef}

0 commit comments

Comments
 (0)