User owes /bin/zsh.00 appears in search after deleting expense

Author: thelullabyy

src/components/OptionListContextProvider.tsx

@@ -50,6 +50,7 @@ function OptionsListContextProvider({children}: OptionsListProviderProps) {
     const [reportAttributes] = useOnyx(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, {canBeMissing: true});
     const prevReportAttributesLocale = usePrevious(reportAttributes?.locale);
     const [reports, {sourceValue: changedReports}] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
+    const prevReports = usePrevious(reports);
     const [, {sourceValue: changedReportActions}] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS, {canBeMissing: true});
     const personalDetails = usePersonalDetails();
     const prevPersonalDetails = usePrevious(personalDetails);
@@ -87,11 +88,14 @@ function OptionsListContextProvider({children}: OptionsListProviderProps) {
     }, [prevReportAttributesLocale, loadOptions, reportAttributes?.locale]);
 
     const changedReportsEntries = useMemo(() => {
-        const result: OnyxCollection<Report> = {};
+        const result: OnyxCollection<Report | null> = {};
 
         Object.keys(changedReports ?? {}).forEach((key) => {
-            const report = reports?.[key];
-            if (report) {
+            let report: Report | null = reports?.[key] ?? null;
+            if (reports?.[key] === undefined && prevReports?.[key]) {
+                report = null;
+            }
+            if (report !== undefined) {
                 result[key] = report;
             }
         });

src/libs/OptionsListUtils.ts

@@ -1200,7 +1200,7 @@ function isReportSelected(reportOption: OptionData, selectedOptions: Array<Parti
 }
 
 function processReport(
-    report: OnyxEntry<Report>,
+    report: OnyxEntry<Report> | null,
     personalDetails: OnyxEntry<PersonalDetailsList>,
 ): {
     reportMapEntry?: [number, Report]; // The entry to add to reportMapForAccountIDs if applicable