Skip to content

Commit 8039748

Browse files
authored
Merge pull request Expensify#66779 from nkdengineer/fix/65498
fix: not here page opens when trying to add US bank account
2 parents 95bdf2b + a069ea4 commit 8039748

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

src/pages/AddPersonalBankAccountPage.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ function AddPersonalBankAccountPage() {
2626
const styles = useThemeStyles();
2727
const {translate} = useLocalize();
2828
const [selectedPlaidAccountId, setSelectedPlaidAccountId] = useState('');
29-
const [isUserValidated] = useOnyx(ONYXKEYS.ACCOUNT, {selector: (account) => account?.validated, canBeMissing: false});
3029
const [personalBankAccount] = useOnyx(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {canBeMissing: true});
3130
const [plaidData] = useOnyx(ONYXKEYS.PLAID_DATA, {canBeMissing: true});
3231
const shouldShowSuccess = personalBankAccount?.shouldShowSuccess ?? false;
@@ -83,7 +82,7 @@ function AddPersonalBankAccountPage() {
8382
shouldShowOfflineIndicator={false}
8483
testID={AddPersonalBankAccountPage.displayName}
8584
>
86-
<FullPageNotFoundView shouldShow={!isUserValidated}>
85+
<FullPageNotFoundView>
8786
<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>
8887
<HeaderWithBackButton
8988
title={translate('bankAccount.addBankAccount')}

src/pages/settings/Wallet/InternationalDepositAccount/substeps/CountrySelection.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import RadioListItem from '@components/SelectionList/RadioListItem';
66
import useDebouncedState from '@hooks/useDebouncedState';
77
import useLocalize from '@hooks/useLocalize';
88
import useNetwork from '@hooks/useNetwork';
9+
import useOnyx from '@hooks/useOnyx';
910
import useThemeStyles from '@hooks/useThemeStyles';
1011
import Navigation from '@libs/Navigation/Navigation';
1112
import searchOptions from '@libs/searchOptions';
@@ -16,6 +17,7 @@ import {fetchCorpayFields} from '@userActions/BankAccounts';
1617
import Text from '@src/components/Text';
1718
import CONST from '@src/CONST';
1819
import type {TranslationPaths} from '@src/languages/types';
20+
import ONYXKEYS from '@src/ONYXKEYS';
1921
import ROUTES from '@src/ROUTES';
2022

2123
function CountrySelection({isEditing, onNext, formValues, resetScreenIndex}: CustomSubStepProps) {
@@ -24,10 +26,15 @@ function CountrySelection({isEditing, onNext, formValues, resetScreenIndex}: Cus
2426
const styles = useThemeStyles();
2527
const [searchValue, debouncedSearchValue, setSearchValue] = useDebouncedState('');
2628
const [currentCountry, setCurrentCountry] = useState(formValues.bankCountry);
29+
const [isUserValidated] = useOnyx(ONYXKEYS.ACCOUNT, {selector: (account) => account?.validated, canBeMissing: false});
2730

2831
const onCountrySelected = useCallback(() => {
2932
if (currentCountry === CONST.COUNTRY.US) {
30-
Navigation.navigate(ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT);
33+
if (isUserValidated) {
34+
Navigation.navigate(ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT);
35+
} else {
36+
Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHOD_VERIFY_ACCOUNT.getRoute(Navigation.getActiveRoute(), ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT));
37+
}
3138
return;
3239
}
3340
if (isEditing && formValues.bankCountry === currentCountry) {
@@ -36,7 +43,7 @@ function CountrySelection({isEditing, onNext, formValues, resetScreenIndex}: Cus
3643
}
3744
fetchCorpayFields(currentCountry);
3845
resetScreenIndex?.(CONST.CORPAY_FIELDS.INDEXES.MAPPING.BANK_ACCOUNT_DETAILS);
39-
}, [currentCountry, formValues.bankCountry, isEditing, onNext, resetScreenIndex]);
46+
}, [currentCountry, formValues.bankCountry, isEditing, onNext, resetScreenIndex, isUserValidated]);
4047

4148
const onSelectionChange = useCallback((country: Option) => {
4249
setCurrentCountry(country.value);

0 commit comments

Comments
 (0)