Adjust to review comments

Author: zfurtak

src/languages/en.ts

@@ -2955,9 +2955,9 @@ const translations = {
             ticketVoided: ({airlineCode, origin, destination, startDate}: FlightParams) =>
                 `Your ticket for flight ${airlineCode} (${origin} → ${destination}) on ${startDate} has been voided.`,
             ticketRefunded: ({airlineCode, origin, destination, startDate}: FlightParams) =>
-                `Your ticket for flight ${airlineCode} (${origin} → ${destination}) on ${startDate} has been refunded or exchange.`,
+                `Your ticket for flight ${airlineCode} (${origin} → ${destination}) on ${startDate} has been refunded or exchanged.`,
             flightCancelled: ({airlineCode, origin, destination, startDate}: FlightParams) =>
-                `Your flight ${airlineCode} (${origin} → ${destination}) on ${startDate}} has been canceled by the airline`,
+                `Your flight ${airlineCode} (${origin} → ${destination}) on ${startDate}} has been canceled by the airline.`,
             flightScheduleChangePending: ({airlineCode}: AirlineParams) => `The airline has proposed a schedule change for flight ${airlineCode}; we are awaiting confirmation.`,
             flightScheduleChangeClosed: ({airlineCode, startDate}: AirlineParams) => `Schedule change confirmed: flight ${airlineCode} now departs at ${startDate}.`,
             flightChanged: ({airlineCode, origin, destination, startDate}: FlightParams) => `Your flight ${airlineCode} (${origin} → ${destination}) on ${startDate} has been changed.`,
@@ -2975,6 +2975,7 @@ const translations = {
             railTicketExchange: ({origin, destination, startDate}: RailTicketParams) => `Your rail ticket for ${origin} → ${destination} on ${startDate} has been exchanged.`,
             railTicketUpdate: ({origin, destination, startDate}: RailTicketParams) => `Your rail ticket for ${origin} → ${destination} on ${startDate} has been updated.`,
             defaultUpdate: ({type}: TravelTypeParams) => `Your ${type} reservation was updated.`,
+            notSupported: 'Not supported travel update.',
         },
     },
     workspace: {

src/languages/es.ts

@@ -2999,6 +2999,7 @@ const translations = {
             railTicketExchange: ({origin, destination, startDate}: RailTicketParams) => `Tu billete de tren de ${origin} a ${destination} para el ${startDate} ha sido cambiado.`,
             railTicketUpdate: ({origin, destination, startDate}: RailTicketParams) => `Tu billete de tren de ${origin} a ${destination} para el ${startDate} ha sido actualizado.`,
             defaultUpdate: ({type}: TravelTypeParams) => `Tu reserva de ${type} fue actualizada.`,
+            notSupported: 'Actualización de viaje no admitida.',
         },
     },
     workspace: {

src/libs/ReportActionsUtils.ts

@@ -12,7 +12,7 @@ import type {TranslationPaths} from '@src/languages/types';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type {Card, Locale, OnyxInputOrEntry, OriginalMessageIOU, PrivatePersonalDetails} from '@src/types/onyx';
-import type {JoinWorkspaceResolution, OriginalMessageChangeLog, OriginalMessageExportIntegration, OriginalMessageTravelUpdate} from '@src/types/onyx/OriginalMessage';
+import type {JoinWorkspaceResolution, OriginalMessageChangeLog, OriginalMessageExportIntegration} from '@src/types/onyx/OriginalMessage';
 import type {PolicyReportFieldType} from '@src/types/onyx/Policy';
 import type Report from '@src/types/onyx/Report';
 import type ReportAction from '@src/types/onyx/ReportAction';
@@ -1531,7 +1531,11 @@ function getMessageOfOldDotReportAction(oldDotAction: PartialReportAction | OldD
 }
 
 function getTravelUpdateMessage(action: ReportAction, formatDate?: (datetime: string, includeTimezone: boolean, isLowercase?: boolean | undefined) => string) {
-    const details = getOriginalMessage(action) as OriginalMessageTravelUpdate;
+    const details = isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.TRAVEL_UPDATE) ? getOriginalMessage(action) : undefined;
+    if (!details) {
+        return translateLocal('travel.updates.notSupported');
+    }
+
     const formattedStartDate = formatDate?.(details.start.date, false) ?? format(details.start.date, CONST.DATE.FNS_DATE_TIME_FORMAT_STRING);
 
     switch (details?.operation) {
@@ -1688,7 +1692,9 @@ function getTravelUpdateMessage(action: ReportAction, formatDate?: (datetime: st
             });
 
         default:
-            return 'Trip was updated';
+            return translateLocal('travel.updates.defaultUpdate', {
+                type: details.type,
+            });
     }
 }
 

src/types/onyx/OriginalMessage.ts

@@ -869,5 +869,4 @@ export type {
     OriginalMessageChangePolicy,
     OriginalMessageUnreportedTransaction,
     OriginalMessageMovedTransaction,
-    OriginalMessageTravelUpdate,
 };