filter out $0 limit cards

Author: grgia

src/libs/CardUtils.ts

@@ -1511,7 +1511,8 @@ function hasDisplayableAssignedCards(cardList: CardList | undefined): boolean {
             CONST.EXPENSIFY_CARD.ACTIVE_STATES.includes(card.state ?? 0) &&
             (isExpensifyCard(card) || !!card.domainName || isPersonalCard(card)) &&
             card.cardName !== CONST.COMPANY_CARDS.CARD_NAME.CASH &&
-            (!isExpensifyCard(card) || !isExpiredCard(card)),
+            (!isExpensifyCard(card) || !isExpiredCard(card)) &&
+            (!isExpensifyCard(card) || !(card.nameValuePairs?.hasCustomUnapprovedExpenseLimit && card.nameValuePairs?.unapprovedExpenseLimit === 0)),
     );
 }
 
@@ -1560,7 +1561,12 @@ function getDisplayableExpensifyCards(cardList: CardList | undefined): Card[] {
 
     const activeCards = filterAllInactiveCards(cardList);
     const activeExpensifyCards = Object.values(activeCards).filter(
-        (card) => isExpensifyCard(card) && !isExpiredCard(card) && card.cardName !== CONST.COMPANY_CARDS.CARD_NAME.CASH && !isTravelCard(card),
+        (card) =>
+            isExpensifyCard(card) &&
+            !isExpiredCard(card) &&
+            card.cardName !== CONST.COMPANY_CARDS.CARD_NAME.CASH &&
+            !isTravelCard(card) &&
+            !(card.nameValuePairs?.hasCustomUnapprovedExpenseLimit && card.nameValuePairs?.unapprovedExpenseLimit === 0),
     );
 
     const sortedCards = lodashSortBy(activeExpensifyCards, getAssignedCardSortKey);

src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveCards.ts

@@ -19,6 +19,10 @@ function useTimeSensitiveCards() {
             continue;
         }
 
+        if (card.nameValuePairs?.hasCustomUnapprovedExpenseLimit && card.nameValuePairs?.unapprovedExpenseLimit === 0) {
+            continue;
+        }
+
         if (isCardWithPotentialFraud(card) && card.nameValuePairs?.possibleFraud?.fraudAlertReportID) {
             cardsWithFraud.push(card);
         }

tests/unit/hooks/useTimeSensitiveCards.test.ts

@@ -220,4 +220,52 @@ describe('useTimeSensitiveCards', () => {
         expect(result.current.cardsWithFraud.at(0)?.cardID).toBe(1);
         expect(result.current.shouldShowReviewCardFraud).toBe(true);
     });
+
+    it('should exclude cards with custom $0 limit from shipping address to-dos', async () => {
+        const zeroLimitCard: Card = {
+            ...createRandomExpensifyCard(1, {state: CONST.EXPENSIFY_CARD.STATE.STATE_NOT_ISSUED}),
+            nameValuePairs: {hasCustomUnapprovedExpenseLimit: true, unapprovedExpenseLimit: 0} as Card['nameValuePairs'],
+        };
+        const cardList: CardList = {'1': zeroLimitCard};
+
+        await Onyx.merge(ONYXKEYS.CARD_LIST, cardList);
+        await waitForBatchedUpdates();
+
+        const {result} = renderHook(() => useTimeSensitiveCards());
+
+        expect(result.current.cardsNeedingShippingAddress).toHaveLength(0);
+        expect(result.current.shouldShowAddShippingAddress).toBe(false);
+    });
+
+    it('should exclude cards with custom $0 limit from activation to-dos', async () => {
+        const zeroLimitCard: Card = {
+            ...createRandomExpensifyCard(1, {state: CONST.EXPENSIFY_CARD.STATE.NOT_ACTIVATED}),
+            nameValuePairs: {hasCustomUnapprovedExpenseLimit: true, unapprovedExpenseLimit: 0} as Card['nameValuePairs'],
+        };
+        const cardList: CardList = {'1': zeroLimitCard};
+
+        await Onyx.merge(ONYXKEYS.CARD_LIST, cardList);
+        await waitForBatchedUpdates();
+
+        const {result} = renderHook(() => useTimeSensitiveCards());
+
+        expect(result.current.cardsNeedingActivation).toHaveLength(0);
+        expect(result.current.shouldShowActivateCard).toBe(false);
+    });
+
+    it('should not exclude cards without custom limit even if unapprovedExpenseLimit is 0', async () => {
+        const groupLimitCard: Card = {
+            ...createRandomExpensifyCard(1, {state: CONST.EXPENSIFY_CARD.STATE.NOT_ACTIVATED}),
+            nameValuePairs: {hasCustomUnapprovedExpenseLimit: false, unapprovedExpenseLimit: 0} as Card['nameValuePairs'],
+        };
+        const cardList: CardList = {'1': groupLimitCard};
+
+        await Onyx.merge(ONYXKEYS.CARD_LIST, cardList);
+        await waitForBatchedUpdates();
+
+        const {result} = renderHook(() => useTimeSensitiveCards());
+
+        expect(result.current.cardsNeedingActivation).toHaveLength(1);
+        expect(result.current.shouldShowActivateCard).toBe(true);
+    });
 });