Skip to content

Commit 82a5138

Browse files
committed
update code
1 parent 4e10bce commit 82a5138

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/components/MoneyRequestConfirmationList.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,13 +441,16 @@ function MoneyRequestConfirmationList({
441441
if (!isDistanceRequest || !transactionID) {
442442
return;
443443
}
444+
if (isReadOnly) {
445+
return;
446+
}
444447
const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES, rate ?? 0);
445448
setMoneyRequestAmount(transactionID, amount, currency ?? '');
446449
isFirstUpdatedDistanceAmount.current = true;
447-
}, [distance, rate, unit, transactionID, currency, isDistanceRequest]);
450+
}, [distance, rate, isReadOnly, unit, transactionID, currency, isDistanceRequest]);
448451

449452
useEffect(() => {
450-
if (!shouldCalculateDistanceAmount || !transactionID) {
453+
if (!shouldCalculateDistanceAmount || !transactionID || isReadOnly) {
451454
return;
452455
}
453456

@@ -459,7 +462,7 @@ function MoneyRequestConfirmationList({
459462
if (isTypeSplit && !isPolicyExpenseChat && amount && transaction?.currency) {
460463
setSplitShares(transaction, amount, currency, participantAccountIDs);
461464
}
462-
}, [shouldCalculateDistanceAmount, distanceRequestAmount, transactionID, currency, isTypeSplit, isPolicyExpenseChat, selectedParticipantsProp, transaction]);
465+
}, [shouldCalculateDistanceAmount, isReadOnly, distanceRequestAmount, transactionID, currency, isTypeSplit, isPolicyExpenseChat, selectedParticipantsProp, transaction]);
463466

464467
const previousTaxCode = usePrevious(transaction?.taxCode);
465468

@@ -780,7 +783,7 @@ function MoneyRequestConfirmationList({
780783
}, [isTypeSplit, translate, payeePersonalDetails, getSplitSectionHeader, splitParticipants, selectedParticipants, isCreateExpenseFlow, isTestReceipt]);
781784

782785
useEffect(() => {
783-
if (!isDistanceRequest || (isMovingTransactionFromTrackExpense && !isPolicyExpenseChat) || !transactionID) {
786+
if (!isDistanceRequest || (isMovingTransactionFromTrackExpense && !isPolicyExpenseChat) || !transactionID || isReadOnly) {
784787
// We don't want to recalculate the distance merchant when moving a transaction from Track Expense to a 1:1 chat, because the distance rate will be the same default P2P rate.
785788
// When moving to a policy chat (e.g. sharing with an accountant), we should recalculate the distance merchant with the policy's rate.
786789
return;
@@ -809,6 +812,7 @@ function MoneyRequestConfirmationList({
809812
transaction,
810813
transactionID,
811814
action,
815+
isReadOnly,
812816
isMovingTransactionFromTrackExpense,
813817
]);
814818

0 commit comments

Comments
 (0)