Merge pull request Expensify#68525 from callstack-internal/remove-broken-connection-for-commercial-feed

Remove broken connection for commercial feed with lastScrapeResult equal 531

Author: robertjchen

src/CONST/index.ts

@@ -91,6 +91,8 @@ const connectionsVideoPaths = {
 // Explicit type annotation is required
 const cardActiveStates: number[] = [2, 3, 4, 7];
 
+const brokenConnectionScrapeStatuses: number[] = [200, 531, 530, 500, 666];
+
 // Hide not issued or not activated cards (states 2, 4) from card filter options in search, as no transactions can be made on cards in these states
 const cardHiddenFromSearchStates: number[] = [2, 4];
 
@@ -3269,6 +3271,7 @@ const CONST = {
         MANAGE_EXPENSIFY_CARDS_ARTICLE_LINK: 'https://help.expensify.com/articles/new-expensify/expensify-card/Manage-Expensify-Cards',
     },
     COMPANY_CARDS: {
+        BROKEN_CONNECTION_IGNORED_STATUSES: brokenConnectionScrapeStatuses,
         CONNECTION_ERROR: 'connectionError',
         STEP: {
             SELECT_BANK: 'SelectBank',

src/libs/CardUtils.ts

@@ -637,7 +637,9 @@ function checkIfFeedConnectionIsBroken(feedCards: Record<string, Card> | undefin
         return false;
     }
 
-    return Object.values(feedCards).some((card) => !isEmptyObject(card) && card.bank !== feedToExclude && card.lastScrapeResult !== 200);
+    return Object.values(feedCards).some(
+        (card) => !isEmptyObject(card) && card.bank !== feedToExclude && card.lastScrapeResult && !CONST.COMPANY_CARDS.BROKEN_CONNECTION_IGNORED_STATUSES.includes(card.lastScrapeResult),
+    );
 }
 
 /**

tests/unit/CardUtilsTest.ts

@@ -149,6 +149,24 @@ const directFeedCardsSingleList: WorkspaceCardsList = {
         state: 3,
     },
 };
+
+const commercialFeedCardsSingleList: WorkspaceCardsList = {
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    '21570652': {
+        accountID: 18439984,
+        bank: CONST.COMPANY_CARD.FEED_BANK_NAME.CHASE,
+        cardID: 21570652,
+        cardName: 'CREDIT CARD...5501',
+        domainName: 'expensify-policy17f617b9fe23d2f1.exfy',
+        fraud: 'none',
+        lastFourPAN: '5501',
+        lastScrape: '',
+        lastUpdated: '',
+        lastScrapeResult: 531,
+        scrapeMinDate: '2024-08-27',
+        state: 3,
+    },
+};
 const directFeedCardsMultipleList: WorkspaceCardsList = {
     // eslint-disable-next-line @typescript-eslint/naming-convention
     '21570655': {
@@ -798,6 +816,10 @@ describe('CardUtils', () => {
             expect(checkIfFeedConnectionIsBroken(directFeedCardsSingleList)).toBeFalsy();
         });
 
+        it('should return false if all of the feed(s) cards has the lastScrapeResult equal to 531', () => {
+            expect(checkIfFeedConnectionIsBroken(commercialFeedCardsSingleList)).toBeFalsy();
+        });
+
         it('should return false if no feed(s) cards are provided', () => {
             expect(checkIfFeedConnectionIsBroken({})).toBeFalsy();
         });

tests/unit/useAccountTabIndicatorStatusTest.ts

@@ -86,12 +86,12 @@ const getMockForStatus = (status: string) =>
             // eslint-disable-next-line @typescript-eslint/naming-convention
             card123: {
                 bank: 'OTHER_BANK',
-                lastScrapeResult: status === CONST.INDICATOR_STATUS.HAS_CARD_CONNECTION_ERROR ? 500 : 200,
+                lastScrapeResult: status === CONST.INDICATOR_STATUS.HAS_CARD_CONNECTION_ERROR ? 403 : 200,
             },
             // eslint-disable-next-line @typescript-eslint/naming-convention
             card456: {
                 bank: 'ANOTHER_BANK',
-                lastScrapeResult: status === CONST.INDICATOR_STATUS.HAS_CARD_CONNECTION_ERROR ? 500 : 200,
+                lastScrapeResult: status === CONST.INDICATOR_STATUS.HAS_CARD_CONNECTION_ERROR ? 403 : 200,
             },
         },
         [ONYXKEYS.SESSION]: {