Merge pull request Expensify#67992 from software-mansion-labs/war-in/revert-sign-in-page-PR-v3

[CP Staging] Revert "Bring back new SignInPage"

Author: mountiny

__mocks__/@ua/react-native-airship.ts

@@ -6,13 +6,6 @@ enum EventType {
     PushReceived = 'com.airship.push_received',
 }
 
-// eslint-disable-next-line no-restricted-syntax
-enum PermissionStatus {
-    Granted = 'granted',
-    Denied = 'denied',
-    NotDetermined = 'not_determined',
-}
-
 // eslint-disable-next-line @typescript-eslint/no-namespace
 namespace iOS {
     /**
@@ -78,4 +71,4 @@ const Airship: Partial<AirshipRoot> = {
 
 export default Airship;
 
-export {EventType, iOS, PermissionStatus};
+export {EventType, iOS};

modules/hybrid-app/android/src/main/java/com/expensify/reactnativehybridapp/ReactNativeHybridApp.kt

@@ -51,22 +51,4 @@ class ReactNativeHybridApp(reactContext: ReactApplicationContext) :
   override fun onURLListenerAdded() {
     Log.d(NAME, "`onURLListenerAdded` should never be called in standalone `New Expensify` app")
   }
-
-  override fun signInToOldDot(
-      autoGeneratedLogin: String,
-      autoGeneratedPassword: String,
-      authToken: String,
-      email: String,
-      policyID: String
-    ) {
-      Log.d(NAME, "`signInToOldDot` should never be called in standalone `New Expensify` app")
-    }
-
-    override fun signOutFromOldDot() {
-      Log.d(NAME, "`signOutFromOldDot` should never be called in standalone `New Expensify` app")
-    }
-
-    override fun clearOldDotAfterSignOut() {
-      Log.d(NAME, "`clearOldDotAfterSignOut` should never be called in standalone `New Expensify` app")
-    }
 }

modules/hybrid-app/ios/ReactNativeHybridApp.mm

@@ -43,18 +43,6 @@ - (void)onURLListenerAdded {
     NSLog(@"[ReactNativeHybridApp] `onURLListenerAdded` should never be called in standalone `New Expensify` app");
 }
 
-- (void)signInToOldDot:(NSString *)autoGeneratedLogin autoGeneratedPassword:(NSString *)autoGeneratedPassword authToken:(NSString *)authToken email:(NSString *)email policyID:(NSString *)policyID {
-    NSLog(@"[ReactNativeHybridApp] `signInToOldDot` should never be called in standalone `New Expensify` app");
-}
-
-- (void)signOutFromOldDot {
-    NSLog(@"[ReactNativeHybridApp] `signOutFromOldDot` should never be called in standalone `New Expensify` app");
-}
-
-- (void)clearOldDotAfterSignOut {
-    NSLog(@"[ReactNativeHybridApp] `clearOldDotAfterSignOut` should never be called in standalone `New Expensify` app");
-}
-
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
     (const facebook::react::ObjCTurboModule::InitParams &)params
 {

modules/hybrid-app/src/NativeReactNativeHybridApp.ts

@@ -12,9 +12,6 @@ export interface Spec extends TurboModule {
     getHybridAppSettings: () => Promise<string | null>;
     getInitialURL(): Promise<string | null>;
     onURLListenerAdded: () => void;
-    signInToOldDot: (autoGeneratedLogin: string, autoGeneratedPassword: string, authToken: string, email: string, policyID: string) => void;
-    signOutFromOldDot: () => void;
-    clearOldDotAfterSignOut: () => void;
 }
 
 export default TurboModuleRegistry.getEnforcing<Spec>('ReactNativeHybridApp');

modules/hybrid-app/src/index.native.ts

@@ -29,15 +29,6 @@ const HybridAppModule: HybridAppModuleType = {
     onURLListenerAdded() {
         ReactNativeHybridApp.onURLListenerAdded();
     },
-    signInToOldDot({autoGeneratedLogin, autoGeneratedPassword, authToken, email, policyID}) {
-        ReactNativeHybridApp.signInToOldDot(autoGeneratedLogin, autoGeneratedPassword, authToken, email, policyID);
-    },
-    signOutFromOldDot() {
-        ReactNativeHybridApp.signOutFromOldDot();
-    },
-    clearOldDotAfterSignOut() {
-        ReactNativeHybridApp.clearOldDotAfterSignOut();
-    },
 };
 
 export default HybridAppModule;

modules/hybrid-app/src/index.ts

@@ -38,18 +38,6 @@ const HybridAppModule: HybridAppModuleType = {
         // eslint-disable-next-line no-console
         console.warn('HybridAppModule: `onURLListenerAdded` should never be called on web');
     },
-    signInToOldDot() {
-        // eslint-disable-next-line no-console
-        console.warn('HybridAppModule: `signInToOldDot` should never be called on web');
-    },
-    signOutFromOldDot() {
-        // eslint-disable-next-line no-console
-        console.warn('HybridAppModule: `signOutFromOldDot` should never be called on web');
-    },
-    clearOldDotAfterSignOut() {
-        // eslint-disable-next-line no-console
-        console.warn('HybridAppModule: `clearOldDotAfterSignOut` should never be called on web');
-    },
 };
 
 export default HybridAppModule;

modules/hybrid-app/src/types.ts

@@ -8,9 +8,6 @@ type HybridAppModuleType = {
     getHybridAppSettings: () => Promise<string | null>;
     getInitialURL(): Promise<string | null>;
     onURLListenerAdded: () => void;
-    signInToOldDot: (args: {autoGeneratedLogin: string; autoGeneratedPassword: string; authToken: string; email: string; policyID: string}) => void;
-    signOutFromOldDot: () => void;
-    clearOldDotAfterSignOut: () => void;
 };
 
 export default HybridAppModuleType;

src/App.tsx

@@ -41,7 +41,6 @@ import {CurrentReportIDContextProvider} from './hooks/useCurrentReportID';
 import useDefaultDragAndDrop from './hooks/useDefaultDragAndDrop';
 import HybridAppHandler from './HybridAppHandler';
 import OnyxUpdateManager from './libs/actions/OnyxUpdateManager';
-import './libs/HybridApp';
 import {AttachmentModalContextProvider} from './pages/media/AttachmentModalScreen/AttachmentModalContext';
 import './setup/backgroundTask';
 import './setup/hybridApp';
@@ -70,57 +69,47 @@ function App() {
                 <InitialURLContextProvider>
                     <HybridAppHandler />
                     <GestureHandlerRootView style={fill}>
-                        {/* Initialize metrics early to ensure the UI renders even when NewDot is hidden.
-                            This is necessary for iOS HybridApp's SignInPage to appear correctly without the bootsplash.
-                            See: https://github.com/Expensify/App/pull/65178#issuecomment-3139026551
-                        */}
-                        <SafeAreaProvider
-                            initialMetrics={{
-                                insets: {top: 0, right: 0, bottom: 0, left: 0},
-                                frame: {x: 0, y: 0, width: 0, height: 0},
-                            }}
+                        <ComposeProviders
+                            components={[
+                                OnyxListItemProvider,
+                                ThemeProvider,
+                                ThemeStylesProvider,
+                                ThemeIllustrationsProvider,
+                                SafeAreaProvider,
+                                HTMLEngineProvider,
+                                PortalProvider,
+                                SafeArea,
+                                LocaleContextProvider,
+                                PopoverContextProvider,
+                                CurrentReportIDContextProvider,
+                                ScrollOffsetContextProvider,
+                                AttachmentModalContextProvider,
+                                PickerStateProvider,
+                                EnvironmentProvider,
+                                CustomStatusBarAndBackgroundContextProvider,
+                                ActiveElementRoleProvider,
+                                ActionSheetAwareScrollViewProvider,
+                                PlaybackContextProvider,
+                                FullScreenContextProvider,
+                                VolumeContextProvider,
+                                VideoPopoverMenuContextProvider,
+                                KeyboardProvider,
+                                KeyboardStateProvider,
+                                SearchRouterContextProvider,
+                                ProductTrainingContextProvider,
+                                InputBlurContextProvider,
+                                FullScreenBlockingViewContextProvider,
+                                FullScreenLoaderContextProvider,
+                            ]}
                         >
-                            <ComposeProviders
-                                components={[
-                                    OnyxListItemProvider,
-                                    ThemeProvider,
-                                    ThemeStylesProvider,
-                                    ThemeIllustrationsProvider,
-                                    HTMLEngineProvider,
-                                    PortalProvider,
-                                    SafeArea,
-                                    LocaleContextProvider,
-                                    PopoverContextProvider,
-                                    CurrentReportIDContextProvider,
-                                    ScrollOffsetContextProvider,
-                                    AttachmentModalContextProvider,
-                                    PickerStateProvider,
-                                    EnvironmentProvider,
-                                    CustomStatusBarAndBackgroundContextProvider,
-                                    ActiveElementRoleProvider,
-                                    ActionSheetAwareScrollViewProvider,
-                                    PlaybackContextProvider,
-                                    FullScreenContextProvider,
-                                    VolumeContextProvider,
-                                    VideoPopoverMenuContextProvider,
-                                    KeyboardProvider,
-                                    KeyboardStateProvider,
-                                    SearchRouterContextProvider,
-                                    ProductTrainingContextProvider,
-                                    InputBlurContextProvider,
-                                    FullScreenBlockingViewContextProvider,
-                                    FullScreenLoaderContextProvider,
-                                ]}
-                            >
-                                <CustomStatusBarAndBackground />
-                                <ErrorBoundary errorMessage="NewExpensify crash caught by error boundary">
-                                    <ColorSchemeWrapper>
-                                        <Expensify />
-                                    </ColorSchemeWrapper>
-                                </ErrorBoundary>
-                                <NavigationBar />
-                            </ComposeProviders>
-                        </SafeAreaProvider>
+                            <CustomStatusBarAndBackground />
+                            <ErrorBoundary errorMessage="NewExpensify crash caught by error boundary">
+                                <ColorSchemeWrapper>
+                                    <Expensify />
+                                </ColorSchemeWrapper>
+                            </ErrorBoundary>
+                            <NavigationBar />
+                        </ComposeProviders>
                     </GestureHandlerRootView>
                 </InitialURLContextProvider>
             </SplashScreenStateContextProvider>

src/CONFIG.ts

@@ -95,18 +95,7 @@ export default {
     GOOGLE_SIGN_IN: {
         // cspell:disable-next-line
         WEB_CLIENT_ID: '921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com',
-        // cspell:disable-next-line
         IOS_CLIENT_ID: '921154746561-s3uqn2oe4m85tufi6mqflbfbuajrm2i3.apps.googleusercontent.com',
-        HYBRID_APP: {
-            // cspell:disable-next-line
-            IOS_CLIENT_ID: '1008697809946-sh04nqq0hea396s1qdqqbj6ia649odb2.apps.googleusercontent.com',
-            WEB_CLIENT_ID: {
-                // cspell:disable-next-line
-                IOS: '1008697809946-5e095eqem3o6ugtpc2rjf7v880tcp28p.apps.googleusercontent.com',
-                // cspell:disable-next-line
-                ANDROID: '240677659774-86pov3adub93cv4b8uj13g7varolmk2l.apps.googleusercontent.com',
-            },
-        },
     },
     GCP_GEOLOCATION_API_KEY: googleGeolocationAPIKey,
     FIREBASE_WEB_CONFIG: {

src/Expensify.tsx

@@ -105,7 +105,6 @@ function Expensify() {
     const [currentOnboardingPurposeSelected] = useOnyx(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED, {canBeMissing: true});
     const [currentOnboardingCompanySize] = useOnyx(ONYXKEYS.ONBOARDING_COMPANY_SIZE, {canBeMissing: true});
     const [onboardingInitialPath] = useOnyx(ONYXKEYS.ONBOARDING_LAST_VISITED_PATH, {canBeMissing: true});
-    const [hybridApp] = useOnyx(ONYXKEYS.HYBRID_APP, {canBeMissing: true});
 
     useDebugShortcut();
     usePriorityMode();
@@ -122,22 +121,10 @@ function Expensify() {
     const isAuthenticated = useIsAuthenticated();
     const autoAuthState = useMemo(() => session?.autoAuthState ?? '', [session]);
 
-    const isSplashReadyToBeHidden = splashScreenState === CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN;
-    const isSplashVisible = splashScreenState === CONST.BOOT_SPLASH_STATE.VISIBLE;
-
     const shouldInit = isNavigationReady && hasAttemptedToOpenPublicRoom && !!preferredLocale;
-    const shouldHideSplash = (isSplashReadyToBeHidden || isSplashVisible) && shouldInit && !hybridApp?.loggedOutFromOldDot;
-
-    // This effect is closing OldDot sign out modal based on splash screen state
-    useEffect(() => {
-        if (!isSplashReadyToBeHidden || !isNavigationReady || !hasAttemptedToOpenPublicRoom || !hybridApp?.loggedOutFromOldDot) {
-            return;
-        }
-
-        setSplashScreenState(CONST.BOOT_SPLASH_STATE.HIDDEN);
-        HybridAppModule.clearOldDotAfterSignOut();
-    }, [hasAttemptedToOpenPublicRoom, hybridApp?.loggedOutFromOldDot, isNavigationReady, isSplashReadyToBeHidden, setSplashScreenState]);
-
+    const isSplashVisible = splashScreenState === CONST.BOOT_SPLASH_STATE.VISIBLE;
+    const isHybridAppReady = splashScreenState === CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN && isAuthenticated;
+    const shouldHideSplash = shouldInit && (CONFIG.IS_HYBRID_APP ? isHybridAppReady : isSplashVisible);
     const initializeClient = () => {
         if (!Visibility.isVisible()) {
             return;