move whole logic to hook

Author: borys3kk

src/components/Search/index.tsx

@@ -402,7 +402,7 @@ function Search({
         // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [isSmallScreenWidth]);
 
-    const {newSearchResultKeys, handleSelectionListScroll, newTransactions} = useSearchHighlightAndScroll({
+    const {newSearchResultKeys, handleSelectionListScroll, newTransactions, hasQueuedHighlights} = useSearchHighlightAndScroll({
         searchResults,
         transactions,
         previousTransactions,
@@ -415,15 +415,15 @@ function Search({
         shouldUseLiveData,
     });
 
-    // Mirror `newSearchResultKeys` into a ref so the post-create-flow `useFocusEffect`
+    // Mirror `hasQueuedHighlights` into a ref so the post-create-flow `useFocusEffect`
     // (which has empty deps) can read the latest value without re-creating its callback.
     // Used to skip the deferral that would otherwise hide the freshly-added row from
     // FlashList during the RHP dismiss transition, which would prevent the highlight
     // animation from ever firing on it.
-    const newSearchResultKeysRef = useRef(newSearchResultKeys);
+    const hasQueuedHighlightsRef = useRef(hasQueuedHighlights);
     useEffect(() => {
-        newSearchResultKeysRef.current = newSearchResultKeys;
-    }, [newSearchResultKeys]);
+        hasQueuedHighlightsRef.current = hasQueuedHighlights;
+    }, [hasQueuedHighlights]);
 
     // There's a race condition in Onyx which makes it return data from the previous Search, so in addition to checking that the data is loaded
     // we also need to check that the searchResults matches the type and status of the current search
@@ -484,7 +484,7 @@ function Search({
             // skip the skeleton-during-transition defer. Otherwise FlashList stays empty
             // for ~1s while the RHP dismiss transition runs, the row never mounts inside
             // the 300ms highlight window, and `useAnimatedHighlightStyle` never fires.
-            if (newSearchResultKeysRef.current && newSearchResultKeysRef.current.size > 0) {
+            if (hasQueuedHighlightsRef.current) {
                 return;
             }
 

src/hooks/useSearchHighlightAndScroll.ts

@@ -312,7 +312,9 @@ function useSearchHighlightAndScroll({
         triggeredByHookRef.current = false;
     };
 
-    return {newSearchResultKeys, handleSelectionListScroll, newTransactions};
+    const hasQueuedHighlights = newSearchResultKeys !== null && newSearchResultKeys.size > 0;
+
+    return {newSearchResultKeys, handleSelectionListScroll, newTransactions, hasQueuedHighlights};
 }
 
 /**