remove redundant manual memoization

Author: inimaga

src/pages/inbox/ConciergeDraftContext.tsx

@@ -1,5 +1,5 @@
 import {getReportChatType} from '@selectors/Report';
-import React, {createContext, useCallback, useContext, useEffect, useMemo, useState} from 'react';
+import React, {createContext, useContext, useEffect, useState} from 'react';
 import useOnyx from '@hooks/useOnyx';
 import {getReportChannelName} from '@libs/actions/Report';
 import Log from '@libs/Log';
@@ -56,9 +56,9 @@ function ConciergeDraftProvider({reportID, children}: React.PropsWithChildren<{r
 function ConciergeDraftGate({reportID, children}: React.PropsWithChildren<{reportID: string}>) {
     const [draft, setDraft] = useState<ConciergeDraft | null>(null);
 
-    const clearDraft = useCallback(() => {
+    const clearDraft = () => {
         setDraft(null);
-    }, []);
+    };
 
     useEffect(() => {
         const channelName = getReportChannelName(reportID);
@@ -98,20 +98,14 @@ function ConciergeDraftGate({reportID, children}: React.PropsWithChildren<{repor
         };
     }, [clearDraft, reportID]);
 
-    const stateValue = useMemo<ConciergeDraftState>(
-        () => ({
-            draftReportAction: draft?.reportAction ?? null,
-            hasActiveDraft: !!draft?.reportAction,
-        }),
-        [draft?.reportAction],
-    );
+    const stateValue: ConciergeDraftState = {
+        draftReportAction: draft?.reportAction ?? null,
+        hasActiveDraft: !!draft?.reportAction,
+    };
 
-    const actionsValue = useMemo<ConciergeDraftActions>(
-        () => ({
-            clearDraft,
-        }),
-        [clearDraft],
-    );
+    const actionsValue: ConciergeDraftActions = {
+        clearDraft,
+    };
 
     return (
         <ConciergeDraftActionsContext.Provider value={actionsValue}>

src/pages/inbox/report/ReportActionsList.tsx

@@ -230,7 +230,7 @@ function ReportActionsList({
         return getSortedReportActions([...sortedVisibleReportActions, draftReportAction], true);
     }, [draftReportAction, sortedVisibleReportActions]);
     const draftMessageHTML = draftReportAction ? getReportActionMessage(draftReportAction)?.html : undefined;
-    const isSyntheticDraftVisible = !!draftReportAction && !sortedVisibleReportActions.some((action) => action.reportActionID === draftReportAction.reportActionID);
+    const isSyntheticDraftVisible = !!draftReportAction && renderedVisibleReportActions !== sortedVisibleReportActions;
     const draftAutoScrollKey = isSyntheticDraftVisible ? `${draftReportAction.reportActionID}:${draftMessageHTML ?? ''}` : '';
     const previousDraftAutoScrollKey = usePrevious(draftAutoScrollKey);
     const topReportAction = renderedVisibleReportActions.at(-1);
@@ -290,12 +290,12 @@ function ReportActionsList({
     }, [reportLastReadTime]);
 
     useEffect(() => {
-        if (!draftReportAction || !sortedVisibleReportActions.some((action) => action.reportActionID === draftReportAction.reportActionID)) {
+        if (!draftReportAction || isSyntheticDraftVisible) {
             return;
         }
 
         clearDraft();
-    }, [clearDraft, draftReportAction, sortedVisibleReportActions]);
+    }, [clearDraft, draftReportAction, isSyntheticDraftVisible]);
 
     const prevUnreadMarkerReportActionID = useRef<string | null>(null);