Merge pull request Expensify#67546 from allgandalf/fixshouldRenderTransferOwnerButton

Remove Onyx.connect() for the key: ONYXKEYS.FUND_LIST in src/libs/shouldRenderTransferOwnerButton/index.native.ts

Author: danieldoglas

src/libs/shouldRenderTransferOwnerButton/index.native.ts

@@ -1,23 +1,7 @@
 import isEmpty from 'lodash/isEmpty';
-import Onyx from 'react-native-onyx';
-import type {OnyxEntry} from 'react-native-onyx';
-import ONYXKEYS from '@src/ONYXKEYS';
-import type {FundList} from '@src/types/onyx';
 import type ShouldRenderTransferOwnerButton from './types';
 
-let fundList: OnyxEntry<FundList>;
-Onyx.connect({
-    key: ONYXKEYS.FUND_LIST,
-    callback: (value) => {
-        if (!value) {
-            return;
-        }
-
-        fundList = value;
-    },
-});
-
-const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = () => {
+const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = (fundList) => {
     return !isEmpty(fundList);
 };
 

src/libs/shouldRenderTransferOwnerButton/types.ts

@@ -1,3 +1,6 @@
-type ShouldRenderTransferOwnerButton = () => boolean;
+import type {OnyxEntry} from 'react-native-onyx';
+import type {FundList} from '@src/types/onyx';
+
+type ShouldRenderTransferOwnerButton = (fundList: OnyxEntry<FundList>) => boolean;
 
 export default ShouldRenderTransferOwnerButton;

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

@@ -80,6 +80,7 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM
     const [cardFeeds] = useCardFeeds(policyID);
     const [cardList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}`, {canBeMissing: true});
     const [customCardNames] = useOnyx(ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES, {canBeMissing: true});
+    const [fundList] = useOnyx(ONYXKEYS.FUND_LIST, {canBeMissing: true});
     const expensifyCardSettings = useExpensifyCardFeeds(policyID);
 
     const [isRemoveMemberConfirmModalVisible, setIsRemoveMemberConfirmModalVisible] = useState(false);
@@ -321,7 +322,7 @@ function WorkspaceMemberDetailsPage({personalDetails, policy, route}: WorkspaceM
                                 </Text>
                             )}
                             {isSelectedMemberOwner && isCurrentUserAdmin && !isCurrentUserOwner ? (
-                                shouldRenderTransferOwnerButton() && (
+                                shouldRenderTransferOwnerButton(fundList) && (
                                     <ButtonDisabledWhenOffline
                                         text={translate('workspace.people.transferOwner')}
                                         onPress={startChangeOwnershipFlow}

tests/unit/ShouldRenderTransferOwnerButtonTest.ts

@@ -0,0 +1,31 @@
+import type {OnyxEntry} from 'react-native-onyx';
+import shouldRenderTransferOwnerButton from '@libs/shouldRenderTransferOwnerButton';
+import type {FundList} from '@src/types/onyx';
+
+describe('shouldRenderTransferOwnerButton', () => {
+    it('should return true if the user has debit card funds', () => {
+        const FUND_LIST: OnyxEntry<FundList> = {
+            defaultCard: {
+                isDefault: true,
+                accountData: {
+                    cardYear: new Date().getFullYear(),
+                    cardMonth: new Date().getMonth() + 1,
+                    additionalData: {
+                        isBillingCard: true,
+                    },
+                },
+            },
+        };
+
+        // eslint-disable-next-line testing-library/render-result-naming-convention
+        const result = shouldRenderTransferOwnerButton(FUND_LIST);
+        expect(result).toBe(true);
+    });
+
+    it('should return false if fund list is empty', () => {
+        const FUND_LIST: OnyxEntry<FundList> = {};
+        // eslint-disable-next-line testing-library/render-result-naming-convention
+        const result = shouldRenderTransferOwnerButton(FUND_LIST);
+        expect(result).toBe(false);
+    });
+});