refactor code

Author: thelullabyy

src/libs/Violations/ViolationsUtils.ts

@@ -290,16 +290,18 @@ const ViolationsUtils = {
                     : getTagViolationsForMultiLevelTags(updatedTransaction, newTransactionViolations, policyTagList, hasDependentTags);
         }
 
-        if (updatedTransaction?.comment?.customUnit?.customUnitRateID && !!getDistanceRateCustomUnitRate(policy, updatedTransaction?.comment?.customUnit?.customUnitRateID)) {
-            newTransactionViolations = reject(newTransactionViolations, {name: CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY});
-        }
-
-        if (updatedTransaction?.comment?.customUnit?.customUnitRateID && !getDistanceRateCustomUnitRate(policy, updatedTransaction.comment.customUnit.customUnitRateID)) {
-            newTransactionViolations.push({
-                name: CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY,
-                type: CONST.VIOLATION_TYPES.VIOLATION,
-                showInReview: true,
-            });
+        const customUnitRateID = updatedTransaction?.comment?.customUnit?.customUnitRateID;
+        if (customUnitRateID) {
+            const distanceRateCustomRate = getDistanceRateCustomUnitRate(policy, customUnitRateID);
+            if (!!distanceRateCustomRate) {
+                newTransactionViolations = reject(newTransactionViolations, {name: CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY});
+            } else {
+                newTransactionViolations.push({
+                    name: CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY,
+                    type: CONST.VIOLATION_TYPES.VIOLATION,
+                    showInReview: true,
+                });
+            }
         }
 
         const isControlPolicy = policy.type === CONST.POLICY.TYPE.CORPORATE;