Merge pull request Expensify#76789 from gelocraft/fix-no-array-for-each-1764898524

[NO QA] fix(eslint): auto-fix unicorn/no-array-for-each rule violatons

Author: roryabraham

src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

@@ -264,7 +264,7 @@ function SuggestionMention({
 
     const getUserMentionOptions = useCallback(
         (personalDetailsParam: PersonalDetailsList | SuggestionPersonalDetailsList | undefined, searchValue = ''): Mention[] => {
-            const suggestions = [];
+            const suggestions: Mention[] = [];
 
             if (CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT.includes(searchValue.toLowerCase())) {
                 suggestions.push({
@@ -315,10 +315,9 @@ function SuggestionMention({
             // At this point we are sure that the details are not null, since empty user details have been filtered in the previous step
             const sortedPersonalDetails = getSortedPersonalDetails(filteredPersonalDetails, localeCompare);
 
-            // eslint-disable-next-line unicorn/no-array-for-each
-            sortedPersonalDetails.slice(0, CONST.AUTO_COMPLETE_SUGGESTER.MAX_AMOUNT_OF_SUGGESTIONS - suggestions.length).forEach((detail) => {
+            for (const detail of sortedPersonalDetails.slice(0, CONST.AUTO_COMPLETE_SUGGESTER.MAX_AMOUNT_OF_SUGGESTIONS - suggestions.length)) {
                 suggestions.push({
-                    text: formatLoginPrivateDomain(getDisplayNameOrDefault(detail), detail?.login),
+                    text: `${formatLoginPrivateDomain(getDisplayNameOrDefault(detail), detail?.login)}`,
                     alternateText: `@${formatLoginPrivateDomain(detail?.login, detail?.login)}`,
                     handle: detail?.login,
                     icons: [
@@ -331,7 +330,7 @@ function SuggestionMention({
                         },
                     ],
                 });
-            });
+            }
 
             return suggestions;
         },
@@ -341,10 +340,9 @@ function SuggestionMention({
     const getRoomMentionOptions = useCallback(
         (searchTerm: string, reportBatch: OnyxCollection<Report>): Mention[] => {
             const filteredRoomMentions: Mention[] = [];
-            // eslint-disable-next-line unicorn/no-array-for-each
-            Object.values(reportBatch ?? {}).forEach((report) => {
+            for (const report of Object.values(reportBatch ?? {})) {
                 if (!canReportBeMentionedWithinPolicy(report, policyID)) {
-                    return;
+                    continue;
                 }
                 if (report?.reportName?.toLowerCase().includes(searchTerm.toLowerCase())) {
                     filteredRoomMentions.push({
@@ -353,7 +351,7 @@ function SuggestionMention({
                         alternateText: report.reportName,
                     });
                 }
-            });
+            }
 
             return lodashSortBy(filteredRoomMentions, 'handle').slice(0, CONST.AUTO_COMPLETE_SUGGESTER.MAX_AMOUNT_OF_SUGGESTIONS);
         },

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

@@ -310,8 +310,7 @@ function IOURequestStepScan({
             billable?: boolean,
             reimbursable = true,
         ) => {
-            // eslint-disable-next-line unicorn/no-array-for-each
-            files.forEach((receiptFile: ReceiptFile, index) => {
+            for (const [index, receiptFile] of files.entries()) {
                 const transaction = transactions.find((item) => item.transactionID === receiptFile.transactionID);
                 const receipt: Receipt = receiptFile.file ?? {};
                 receipt.source = receiptFile.source;
@@ -366,7 +365,7 @@ function IOURequestStepScan({
                         transactionViolations,
                     });
                 }
-            });
+            }
         },
         [
             transactions,

src/pages/iou/request/step/IOURequestStepScan/index.tsx

@@ -369,8 +369,7 @@ function IOURequestStepScan({
             billable?: boolean,
             reimbursable = true,
         ) => {
-            // eslint-disable-next-line unicorn/no-array-for-each
-            files.forEach((receiptFile: ReceiptFile, index) => {
+            for (const [index, receiptFile] of files.entries()) {
                 const transaction = transactions.find((item) => item.transactionID === receiptFile.transactionID);
                 const receipt: Receipt = receiptFile.file ?? {};
                 receipt.source = receiptFile.source;
@@ -426,7 +425,7 @@ function IOURequestStepScan({
                         transactionViolations,
                     });
                 }
-            });
+            }
         },
         [
             backToReport,

src/pages/workspace/accounting/intacct/SageIntacctEntityPage.tsx

@@ -27,15 +27,14 @@ function SageIntacctEntityPage({policy}: WithPolicyProps) {
             isSelected: entityID === '',
         },
     ];
-    // eslint-disable-next-line unicorn/no-array-for-each
-    policy?.connections?.intacct?.data?.entities.forEach((entity) => {
+    for (const entity of policy?.connections?.intacct?.data?.entities ?? []) {
         sections.push({
             text: entity.name,
             value: entity.name,
             keyForList: entity.id,
             isSelected: entity.id === entityID,
         });
-    });
+    }
 
     const saveSelection = ({keyForList}: ListItem) => {
         updateSageIntacctEntity(policyID, keyForList ?? '', entityID);

src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

@@ -53,10 +53,11 @@ function ApprovalWorkflowEditor({approvalWorkflow, removeApprovalWorkflow, polic
         (index: number) => {
             let pendingAction: PendingAction | undefined;
             if (index === 0) {
-                // eslint-disable-next-line unicorn/no-array-for-each
-                approvalWorkflow?.members?.forEach((member) => {
-                    pendingAction = pendingAction ?? member.pendingFields?.submitsTo;
-                });
+                if (approvalWorkflow?.members) {
+                    for (const member of approvalWorkflow.members) {
+                        pendingAction = pendingAction ?? member.pendingFields?.submitsTo;
+                    }
+                }
                 return pendingAction;
             }
             const previousApprover = approvalWorkflow?.approvers.at(index - 1);