fix: prevent side panel actions when side panel NVP is undefined

Author: blazejkustra

src/components/SidePanel/index.tsx

@@ -3,8 +3,14 @@ import useSidePanel from '@hooks/useSidePanel';
 import Help from './HelpModal';
 
 function SidePanel() {
-    const {isSidePanelTransitionEnded, shouldHideSidePanel, sidePanelTranslateX, shouldHideSidePanelBackdrop, closeSidePanel} = useSidePanel();
+    const {sidePanelNVP, isSidePanelTransitionEnded, shouldHideSidePanel, sidePanelTranslateX, shouldHideSidePanelBackdrop, closeSidePanel} = useSidePanel();
 
+    // Side panel can't be displayed if NVP is undefined
+    if (!sidePanelNVP) {
+        return null;
+    }
+
+    // Hide side panel once animation ends
     if (isSidePanelTransitionEnded && shouldHideSidePanel) {
         return null;
     }

src/hooks/useSidePanel.ts

@@ -91,20 +91,30 @@ function useSidePanel() {
     }, [shouldHideSidePanel, shouldApplySidePanelOffset]);
 
     const openSidePanel = useCallback(() => {
+        // User shouldn't be able to open side panel if side panel NVP is undefined
+        if (!sidePanelNVP) {
+            return;
+        }
+
         setIsSidePanelTransitionEnded(false);
         KeyboardUtils.dismiss();
         SidePanelActions.openSidePanel(!isExtraLargeScreenWidth);
-    }, [isExtraLargeScreenWidth]);
+    }, [isExtraLargeScreenWidth, sidePanelNVP]);
 
     const closeSidePanel = useCallback(
         (shouldUpdateNarrow = false) => {
+            // User shouldn't be able to close side panel if side panel NVP is undefined
+            if (!sidePanelNVP) {
+                return;
+            }
+
             setIsSidePanelTransitionEnded(false);
             SidePanelActions.closeSidePanel(!isExtraLargeScreenWidth || shouldUpdateNarrow);
 
             // Focus the composer after closing the Side Panel
             focusComposerWithDelay(ReportActionComposeFocusManager.composerRef.current, CONST.ANIMATED_TRANSITION + CONST.COMPOSER_FOCUS_DELAY)(true);
         },
-        [isExtraLargeScreenWidth],
+        [isExtraLargeScreenWidth, sidePanelNVP],
     );
 
     return {