Merge pull request Expensify#67697 from samranahm/66829/remove-tooSmallError-from-validateAttachmentFile

Remove minimum file size restriction for attachments

Author: marcaaron

src/libs/fileDownload/FileUtils.ts

@@ -436,7 +436,7 @@ const validateAttachment = (file: FileObject, isCheckingMultipleFiles?: boolean,
         return isCheckingMultipleFiles ? CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE_MULTIPLE : CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE;
     }
 
-    if ((file?.size ?? 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) {
+    if (isValidatingReceipt && (file?.size ?? 0) < CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE) {
         return CONST.FILE_VALIDATION_ERRORS.FILE_TOO_SMALL;
     }
 

tests/unit/FileUtilsTest.ts

@@ -4,6 +4,11 @@ import * as FileUtils from '../../src/libs/fileDownload/FileUtils';
 
 jest.useFakeTimers();
 
+const createMockFile = (name: string, size: number) => ({
+    name,
+    size,
+});
+
 describe('FileUtils', () => {
     describe('splitExtensionFromFileName', () => {
         it('should return correct file name and extension', () => {
@@ -38,4 +43,42 @@ describe('FileUtils', () => {
             expect(actualFileName).toEqual(expectedFileName.replace(CONST.REGEX.ILLEGAL_FILENAME_CHARACTERS, '_'));
         });
     });
+
+    describe('validateAttachment', () => {
+        it('should not return FILE_TOO_SMALL when validating small attachment', () => {
+            const file = createMockFile('file.csv', CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE - 1);
+            const error = FileUtils.validateAttachment(file, false, false);
+            expect(error).not.toBe(CONST.FILE_VALIDATION_ERRORS.FILE_TOO_SMALL);
+        });
+
+        it('should return FILE_TOO_SMALL when validating small receipt', () => {
+            const file = createMockFile('receipt.jpg', CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE - 1);
+            const error = FileUtils.validateAttachment(file, false, true);
+            expect(error).toBe(CONST.FILE_VALIDATION_ERRORS.FILE_TOO_SMALL);
+        });
+
+        it('should return FILE_TOO_LARGE for large non-image file', () => {
+            const file = createMockFile('file.pdf', CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE + 1);
+            const error = FileUtils.validateAttachment(file);
+            expect(error).toBe(CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE);
+        });
+
+        it('should return FILE_TOO_LARGE_MULTIPLE when checking multiple files', () => {
+            const file = createMockFile('file.pdf', CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE + 1);
+            const error = FileUtils.validateAttachment(file, true);
+            expect(error).toBe(CONST.FILE_VALIDATION_ERRORS.FILE_TOO_LARGE_MULTIPLE);
+        });
+
+        it('should return WRONG_FILE_TYPE for invalid receipt extension', () => {
+            const file = createMockFile('receipt.exe', CONST.API_ATTACHMENT_VALIDATIONS.RECEIPT_MAX_SIZE - 1);
+            const error = FileUtils.validateAttachment(file, false, true);
+            expect(error).toBe(CONST.FILE_VALIDATION_ERRORS.WRONG_FILE_TYPE);
+        });
+
+        it('should return empty string for valid image receipt', () => {
+            const file = createMockFile('receipt.jpg', CONST.API_ATTACHMENT_VALIDATIONS.RECEIPT_MAX_SIZE - 1);
+            const error = FileUtils.validateAttachment(file, false, true);
+            expect(error).toBe('');
+        });
+    });
 });