Merge pull request Expensify#88386 from callstack-internal/bulk-edit-bug-merchant-not-disabled

fix: bulk edit, merchant should be disabled for unreported per diem

Author: marcaaron

src/pages/Search/SearchEditMultiple/SearchEditMultiplePage.tsx

@@ -28,6 +28,7 @@ import type {TransactionChanges} from '@src/types/onyx/Transaction';
 import {
     areAllTransactionsExpenseCompatible,
     getTransactionEditContext,
+    hasCustomUnitMerchantInSelection,
     isBulkEditTaxTrackingEnabled,
     withSnapshotReportActions,
     withSnapshotReports,
@@ -77,8 +78,7 @@ function SearchEditMultiplePage() {
 
     const hasPartiallyEditableTransaction = isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.AMOUNT);
 
-    const hasPartiallyEditableMerchantTransaction =
-        isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.MERCHANT) || selectedTransactionContexts.some(({transaction}) => isDistanceRequest(transaction));
+    const hasPartiallyEditableMerchantTransaction = isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.MERCHANT) || hasCustomUnitMerchantInSelection(selectedTransactionContexts);
 
     const hasPartiallyEditableTaxRateTransaction =
         isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.TAX_RATE) || selectedTransactionContexts.some(({transaction}) => isDistanceRequest(transaction));

src/pages/Search/SearchEditMultiple/SearchEditMultipleUtils.ts

@@ -1,7 +1,7 @@
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
 import {getIOUActionForTransactionID} from '@libs/ReportActionsUtils';
 import {isIOUReport} from '@libs/ReportUtils';
-import {getTagArrayFromName} from '@libs/TransactionUtils';
+import {getTagArrayFromName, isDistanceRequest, isPerDiemRequest} from '@libs/TransactionUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {Policy, Report, ReportActions, SearchResults, Transaction} from '@src/types/onyx';
@@ -62,6 +62,14 @@ function getTransactionEditContext(
     return {transaction, report, reportAction, transactionPolicy};
 }
 
+/**
+ * Distance and per-diem transactions have a system-derived merchant that cannot be user-edited
+ * regardless of whether the transaction is reported or unreported.
+ */
+function hasCustomUnitMerchantInSelection(selectedTransactionContexts: Array<{transaction: Transaction}>): boolean {
+    return selectedTransactionContexts.some(({transaction}) => isDistanceRequest(transaction) || isPerDiemRequest(transaction));
+}
+
 /**
  * Category/Tag/Tax only apply to expense/invoice reports and unreported (track) expenses.
  * Returns true only when every selected transaction is eligible.
@@ -149,9 +157,10 @@ function withSnapshotReports(onyxReports: OnyxCollection<Report> | undefined, sn
 }
 
 export {
-    areAllTransactionsExpenseCompatible,
     getCommonDependentTag,
     getTransactionEditContext,
+    hasCustomUnitMerchantInSelection,
+    areAllTransactionsExpenseCompatible,
     isBulkEditTaxTrackingEnabled,
     withSnapshotTransactions,
     withSnapshotReportActions,

tests/unit/SearchEditMultipleUtilsTest.ts

@@ -4,6 +4,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import type {Policy, Report, SearchResults, Transaction} from '@src/types/onyx';
 import {
     areAllTransactionsExpenseCompatible,
+    hasCustomUnitMerchantInSelection,
     isBulkEditTaxTrackingEnabled,
     withSnapshotReports,
     withSnapshotTransactions,
@@ -15,6 +16,7 @@ const POLICY_C = 'policyC';
 const REPORT_ID = 'report1';
 const TRANSACTION_ID_1 = 'tx1';
 const TRANSACTION_ID_2 = 'tx2';
+const TRANSACTION_ID_3 = 'tx3';
 
 function makeTransaction(transactionID: string, reportID: string): Transaction {
     return {transactionID, reportID, amount: 100, currency: 'USD', created: '2025-01-01', comment: {}} as Transaction;
@@ -138,6 +140,31 @@ describe('SearchEditMultipleUtils', () => {
         });
     });
 
+    describe('hasCustomUnitMerchantInSelection', () => {
+        const manualTransaction = {transactionID: TRANSACTION_ID_1, reportID: 'report1', comment: {}} as Transaction;
+        const perDiemTransaction = {transactionID: TRANSACTION_ID_2, reportID: CONST.REPORT.UNREPORTED_REPORT_ID, iouRequestType: CONST.IOU.REQUEST_TYPE.PER_DIEM} as unknown as Transaction;
+        const distanceTransaction = {transactionID: TRANSACTION_ID_3, reportID: CONST.REPORT.UNREPORTED_REPORT_ID, iouRequestType: CONST.IOU.REQUEST_TYPE.DISTANCE} as unknown as Transaction;
+
+        it('returns true when any transaction is an unreported per-diem request', () => {
+            const contexts = [{transaction: manualTransaction}, {transaction: perDiemTransaction}];
+            expect(hasCustomUnitMerchantInSelection(contexts)).toBe(true);
+        });
+
+        it('returns true when any transaction is a distance request', () => {
+            const contexts = [{transaction: manualTransaction}, {transaction: distanceTransaction}];
+            expect(hasCustomUnitMerchantInSelection(contexts)).toBe(true);
+        });
+
+        it('returns false when no transaction is a distance or per-diem request', () => {
+            const contexts = [{transaction: manualTransaction}];
+            expect(hasCustomUnitMerchantInSelection(contexts)).toBe(false);
+        });
+
+        it('returns false for an empty selection', () => {
+            expect(hasCustomUnitMerchantInSelection([])).toBe(false);
+        });
+    });
+
     describe('areAllTransactionsExpenseCompatible', () => {
         const expenseReport = {reportID: 'expenseReport1', type: CONST.REPORT.TYPE.EXPENSE} as Report;
         const iouReport = {reportID: 'iouReport1', type: CONST.REPORT.TYPE.IOU} as Report;