Merge branch 'main' into perf-scan-page/preload-fab-icons

Author: rinej

.github/workflows/publishReactNativeAndroidArtifacts.yml

@@ -126,7 +126,7 @@ jobs:
     name: Build and Publish React Native Artifacts
     runs-on: ${{ github.repository_owner == 'Expensify' && 'blacksmith-16vcpu-ubuntu-2404' || 'blacksmith-2vcpu-ubuntu-2404' }}
     needs: verifyPatches
-    if: needs.verifyPatches.outputs.build_targets != '' 
+    if: needs.verifyPatches.outputs.build_targets != ''
     strategy:
       # Disable fail-fast to prevent cancelling both jobs when only one needs to be stopped due to concurrency limits
       fail-fast: false
@@ -160,7 +160,7 @@ jobs:
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@06832c7b30a0129d7fb559bcc6e43d26f6374244
-      
+
       - name: Determine new patched RN version
         id: getNewPatchedVersion
         run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> "$GITHUB_OUTPUT"
@@ -175,14 +175,26 @@ jobs:
           echo "Version: ${{ env.PATCHED_VERSION }}"
           echo "Patches hash: ${{ env.PATCHES_HASH }}"
           export ORG_GRADLE_PROJECT_reactNativeArchitectures="armeabi-v7a,arm64-v8a,x86,x86_64"
-          ./gradlew buildReactNativeArtifacts -PpatchedArtifacts.forceBuildFromSource=true -x lint -x test -x check
+
+          # Exclude ktfmt and test tasks from the included react-native build
+          EXCLUDE_TASKS=(
+            -x :react-native:packages:react-native:ReactAndroid:ktfmtCheck
+            -x :react-native:packages:react-native:ReactAndroid:ktfmtCheckMain
+            -x :react-native:packages:react-native:ReactAndroid:ktfmtCheckScripts
+            -x :react-native:packages:react-native:ReactAndroid:testDebugOptimizedUnitTest
+            -x :react-native:packages:react-native:ReactAndroid:testDebugUnitTest
+            -x :react-native:packages:react-native:ReactAndroid:testReleaseUnitTest
+          )
+
+          ./gradlew buildReactNativeArtifacts -PpatchedArtifacts.forceBuildFromSource=true -x lint -x test -x check "${EXCLUDE_TASKS[@]}"
           ./gradlew publishReactNativeArtifacts -PpatchedArtifacts.forceBuildFromSource=true
         env:
           GH_PUBLISH_ACTOR: ${{ github.actor }}
           GH_PUBLISH_TOKEN: ${{ github.token }}
           IS_HYBRID_BUILD: ${{ matrix.is_hybrid }}
           PATCHED_VERSION: ${{ steps.getNewPatchedVersion.outputs.NEW_PATCHED_VERSION }}
           PATCHES_HASH: ${{ matrix.is_hybrid == 'true' && needs.verifyPatches.outputs.hybrid_app_patches_hash || needs.verifyPatches.outputs.standalone_patches_hash }}
+          CMAKE_VERSION: 3.31.6
 
       - name: Announce failed workflow in Slack
         if: ${{ failure() }}

Mobile-Expensify

@@ -111,8 +111,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009034103
-        versionName "9.3.41-3"
+        versionCode 1009034203
+        versionName "9.3.42-3"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

android/app/build.gradle

@@ -37,9 +37,8 @@ if(settings.extensions.patchedArtifacts.buildFromSource) {
     }
 }
 
-apply from: new File(["node", "--print", "require.resolve('expo/package.json')"].execute(null, rootDir).text.trim(), "../scripts/autolinking.gradle")
-useExpoModules()
 expoAutolinking {
-    projectRoot = file(rootDir)
+    projectRoot = file('../')
+    searchPaths = ['node_modules']
     useExpoModules()
 }

android/settings.gradle

@@ -1,4 +1,5 @@
-import type {Chunk, Compiler} from 'webpack';
+import path from 'path';
+import type {Chunk, Compiler, NormalModule} from 'webpack';
 import webpack from 'webpack';
 // @libs alias is not available in Node.js/Storybook context — use relative path instead
 // @ts-expect-error -- Can't use .ts extensions without allowImportingTsExtensions in tsconfig
@@ -37,6 +38,9 @@ function createTimingRuntimeModule(): webpack.RuntimeModule {
  */
 class ModuleInitTimingPlugin {
     apply(compiler: Compiler): void {
+        if (compiler.isChild()) {
+            return;
+        }
         compiler.hooks.compilation.tap(PLUGIN_NAME, (compilation) => {
             // Ensure webpack generates the __webpack_require__.i interception
             // mechanism for every chunk that has a runtime.
@@ -49,6 +53,29 @@ class ModuleInitTimingPlugin {
                 compilation.addRuntimeModule(chunk, createTimingRuntimeModule());
             });
         });
+
+        // Emit module-names.json once per build (after all compilations are sealed).
+        // Using compiler.hooks.emit rather than compilation.hooks.processAssets avoids
+        // conflicts when multiple compilation rounds run in the same build (e.g. Sentry plugin).
+        compiler.hooks.emit.tap(PLUGIN_NAME, (compilation) => {
+            const names: Record<string, string> = {};
+            for (const module of compilation.modules) {
+                const id = compilation.chunkGraph.getModuleId(module);
+                if (id === null) {
+                    continue;
+                }
+                const resource = 'resource' in module ? (module as NormalModule).resource : undefined;
+                if (!resource || resource.includes('node_modules')) {
+                    continue;
+                }
+                const relativePath = `./${path.relative(compiler.context, resource).replaceAll('\\', '/')}`;
+                names[String(id)] = relativePath;
+            }
+            if (Object.keys(names).length > 0) {
+                // eslint-disable-next-line no-param-reassign
+                compilation.assets['module-names.json'] = new webpack.sources.RawSource(JSON.stringify(names));
+            }
+        });
     }
 }
 

assets/images/multifactorAuthentication/open-padlock-green.svg

@@ -710,7 +710,7 @@ Do not use dynamic routes when:
 `DYNAMIC_ROUTES` in `src/ROUTES.ts`: each entry has:
 
 - `path`: The URL suffix (e.g. `'verify-account'`).
-- `entryScreens`: List of screen names that are allowed to have this suffix appended (access control; see [Entry Screens (Access Control)](#entry-screens-access-control)).
+- `entryScreens`: List of screen names that are allowed to have this suffix appended (access control; see [Entry Screens (Access Control)](#entry-screens-access-control)). Use `['*']` to allow all screens.
 
 `createDynamicRoute(suffix)` — [`createDynamicRoute.ts`](src/libs/Navigation/helpers/createDynamicRoute.ts). Accepts a `DynamicRouteSuffix` (from `DYNAMIC_ROUTES`), appends it to the current active route and returns the full route. Use the following when navigating to a dynamic route:
 
@@ -731,6 +731,24 @@ When parsing a URL, `src/libs/Navigation/helpers/getStateFromPath.ts` resolves t
 
 When adding or extending a dynamic route, list every screen that should be able to open it (e.g. `SCREENS.SETTINGS.WALLET.ROOT` for Verify Account from Wallet).
 
+#### Wildcard access (`'*'`)
+
+Setting `entryScreens` to `['*']` grants access to the dynamic route from any screen. This bypasses per-screen authorization entirely for that route.
+
+```ts
+KEYBOARD_SHORTCUTS: {
+    path: 'keyboard-shortcuts',
+    entryScreens: ['*'],
+},
+```
+
+> [!CAUTION]
+> **Use `'*'` only when the dynamic route genuinely needs to be reachable from every screen.**
+> If only a subset of screens should access the route, list them explicitly.
+> Overusing `'*'` weakens the access control that `entryScreens` provides
+> and makes it harder to reason about which screens can trigger a given flow.
+> When in doubt, prefer an explicit list.
+
 ### Current limitations (work in progress)
 
 - **Path parameters:** Suffixes must not include path params (e.g. `a/:reportID`). Query parameters are supported - see [Dynamic routes with query parameters](#dynamic-routes-with-query-parameters).

assets/images/simple-illustrations/simple-illustration__encryption-passkeys.svg

@@ -8,7 +8,7 @@ This doc explains when and how to use the `SelectionList` and `SelectionListWith
 There are two main components:
 
 - [**`SelectionList`**](../src/components/SelectionList/BaseSelectionList.tsx) - For displaying a single array of data (no sections)
-- [**`SelectionListWithSections`**](../src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx) - For displaying data organized into multiple sections
+- [**`SelectionListWithSections`**](../src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx) - For displaying data organized into multiple sections
 
 ## When to Use Each Component
 
@@ -59,13 +59,18 @@ There are two main components:
 ```tsx
 <SelectionListWithSections
     sections={[
-        { title: 'Recent', data: recentContacts },
-        { title: 'All Contacts', data: allContacts },
+        { title: 'Recent', data: recentContacts, sectionIndex: 0 },
+        { title: 'All Contacts', data: allContacts, sectionIndex: 1 },
     ]}
     ListItem={UserListItem}
     onSelectRow={handleSelectContact}
     shouldShowTextInput
-    textInputLabel="Search contacts"
+    textInputOptions={{
+        label: "Search items",
+        value: searchText,
+        onChangeText: setSearchText,
+        headerMessage
+    }}
 />
 ```
 

config/webpack/ModuleInitTimingPlugin.ts

@@ -205,6 +205,7 @@
         "ecash",
         "ecconnrefused",
         "econn",
+        "EDDSA",
         "EDIFACT",
         "Egencia",
         "Electromedical",
@@ -303,6 +304,7 @@
         "gradlew",
         "Grantmaking",
         "groupmonth",
+        "groupweek",
         "gscb",
         "gsib",
         "gsst",
@@ -597,6 +599,7 @@
         "reactnativebackgroundtask",
         "reactnativehybridapp",
         "reactnativekeycommand",
+        "reannounce",
         "reauthentication",
         "Reauthenticator",
         "Rebooked",