Skip to content

Commit 9b1b9bd

Browse files
grgiaclaude
andcommitted
Rename SyncPolicyToMergeHR to SyncPolicyToMerge and flip to write
The BE command is SyncPolicyToMerge and is registered as a write, not a read. Updates the FE constant, parameter file/type, dispatcher in connections/index.ts, and the syncMergeHR call site to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 54e5655 commit 9b1b9bd

6 files changed

Lines changed: 18 additions & 14 deletions

File tree

src/libs/API/parameters/SyncPolicyToMergeHRParams.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
type SyncPolicyToMergeParams = {
2+
/** The ID of the policy to sync */
3+
policyID: string;
4+
};
5+
6+
export default SyncPolicyToMergeParams;

src/libs/API/parameters/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export type {default as ConnectPolicyToZenefitsParams} from './ConnectPolicyToZe
2828
export type {default as OpenPolicyProfilePageParams} from './OpenPolicyProfilePageParams';
2929
export type {default as OpenPolicyInitialPageParams} from './OpenPolicyInitialPageParams';
3030
export type {default as SyncPolicyToGustoParams} from './SyncPolicyToGustoParams';
31-
export type {default as SyncPolicyToMergeHRParams} from './SyncPolicyToMergeHRParams';
31+
export type {default as SyncPolicyToMergeParams} from './SyncPolicyToMergeParams';
3232
export type {default as SyncPolicyToZenefitsParams} from './SyncPolicyToZenefitsParams';
3333
export type {default as SyncPolicyToQuickbooksOnlineParams} from './SyncPolicyToQuickbooksOnlineParams';
3434
export type {default as SyncPolicyToXeroParams} from './SyncPolicyToXeroParams';

src/libs/API/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ const WRITE_COMMANDS = {
390390
UPDATE_GUSTO_FINAL_APPROVER: 'UpdateGustoFinalApprover',
391391
UPDATE_MERGE_HR_APPROVAL_MODE: 'UpdateMergeHRApprovalMode',
392392
UPDATE_MERGE_HR_FINAL_APPROVER: 'UpdateMergeHRFinalApprover',
393+
SYNC_POLICY_TO_MERGE: 'SyncPolicyToMerge',
393394
UPDATE_ZENEFITS_APPROVAL_MODE: 'UpdateZenefitsApprovalMode',
394395
UPDATE_ZENEFITS_FINAL_APPROVER: 'UpdateZenefitsFinalApprover',
395396
DOWNGRADE_TO_TEAM: 'Policy_DowngradeToTeam',
@@ -1022,6 +1023,7 @@ type WriteCommandParameters = {
10221023
[WRITE_COMMANDS.UPDATE_GUSTO_FINAL_APPROVER]: Parameters.UpdateGustoFinalApproverParams;
10231024
[WRITE_COMMANDS.UPDATE_MERGE_HR_APPROVAL_MODE]: Parameters.UpdateMergeHRApprovalModeParams;
10241025
[WRITE_COMMANDS.UPDATE_MERGE_HR_FINAL_APPROVER]: Parameters.UpdateMergeHRFinalApproverParams;
1026+
[WRITE_COMMANDS.SYNC_POLICY_TO_MERGE]: Parameters.SyncPolicyToMergeParams;
10251027
[WRITE_COMMANDS.UPDATE_ZENEFITS_APPROVAL_MODE]: Parameters.UpdateZenefitsApprovalModeParams;
10261028
[WRITE_COMMANDS.UPDATE_ZENEFITS_FINAL_APPROVER]: Parameters.UpdateZenefitsFinalApproverParams;
10271029
[WRITE_COMMANDS.REQUEST_TAX_EXEMPTION]: null;
@@ -1278,7 +1280,6 @@ const READ_COMMANDS = {
12781280
SYNC_POLICY_TO_QUICKBOOKS_DESKTOP: 'SyncPolicyToQuickbooksDesktop',
12791281
SYNC_POLICY_TO_GUSTO: 'SyncPolicyToGusto',
12801282
SYNC_POLICY_TO_ZENEFITS: 'SyncPolicyToZenefits',
1281-
SYNC_POLICY_TO_MERGE_HR: 'SyncPolicyToMergeHR',
12821283
SYNC_POLICY_TO_FINANCIAL_FORCE: 'SyncPolicyToFinancialForce',
12831284
CONNECT_POLICY_TO_FINANCIAL_FORCE: 'ConnectPolicyToFinancialForce',
12841285
OPEN_REIMBURSEMENT_ACCOUNT_PAGE: 'OpenReimbursementAccountPage',
@@ -1382,7 +1383,6 @@ type ReadCommandParameters = {
13821383
[READ_COMMANDS.SYNC_POLICY_TO_QUICKBOOKS_DESKTOP]: Parameters.SyncPolicyToQuickbooksDesktopParams;
13831384
[READ_COMMANDS.SYNC_POLICY_TO_GUSTO]: Parameters.SyncPolicyToGustoParams;
13841385
[READ_COMMANDS.SYNC_POLICY_TO_ZENEFITS]: Parameters.SyncPolicyToZenefitsParams;
1385-
[READ_COMMANDS.SYNC_POLICY_TO_MERGE_HR]: Parameters.SyncPolicyToMergeHRParams;
13861386
[READ_COMMANDS.SYNC_POLICY_TO_FINANCIAL_FORCE]: {policyID: string};
13871387
[READ_COMMANDS.OPEN_REIMBURSEMENT_ACCOUNT_PAGE]: Parameters.OpenReimbursementAccountPageParams;
13881388
[READ_COMMANDS.OPEN_WORKSPACE_VIEW]: Parameters.OpenWorkspaceViewParams;

src/libs/actions/connections/MergeHR.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type {OnyxUpdate} from 'react-native-onyx';
22
import Onyx from 'react-native-onyx';
33
import type {ValueOf} from 'type-fest';
4-
import {read, write} from '@libs/API';
4+
import {write} from '@libs/API';
55
import type {ConnectPolicyToMergeParams} from '@libs/API/parameters';
66
import {READ_COMMANDS, WRITE_COMMANDS} from '@libs/API/types';
77
import {getCommandURL} from '@libs/ApiUtils';
@@ -43,7 +43,7 @@ function syncMergeHR(policyID: string) {
4343
},
4444
];
4545

46-
read(READ_COMMANDS.SYNC_POLICY_TO_MERGE_HR, {policyID}, {optimisticData, failureData});
46+
write(WRITE_COMMANDS.SYNC_POLICY_TO_MERGE, {policyID}, {optimisticData, failureData});
4747
}
4848

4949
/**

src/libs/actions/connections/index.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
1111
import type {ConnectionName, Connections, PolicyConnectionName, PolicyConnectionSyncProgress} from '@src/types/onyx/Policy';
1212
import type Policy from '@src/types/onyx/Policy';
1313
import {isEmptyObject} from '@src/types/utils/EmptyObject';
14+
import {syncMergeHR} from './MergeHR';
1415

1516
type ConnectionNameExceptNetSuite = Exclude<ConnectionName, typeof CONST.POLICY.CONNECTIONS.NAME.NETSUITE>;
1617

@@ -135,9 +136,6 @@ function getSyncConnectionParameters(connectionName: PolicyConnectionName) {
135136
case CONST.POLICY.CONNECTIONS.NAME.ZENEFITS: {
136137
return {readCommand: READ_COMMANDS.SYNC_POLICY_TO_ZENEFITS, stageInProgress: CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.ZENEFITS_SYNC_TITLE};
137138
}
138-
case CONST.POLICY.CONNECTIONS.NAME.MERGE_HR: {
139-
return {readCommand: READ_COMMANDS.SYNC_POLICY_TO_MERGE_HR, stageInProgress: CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.MERGE_HR_SYNC_TITLE};
140-
}
141139
case CONST.POLICY.CONNECTIONS.NAME.CERTINIA: {
142140
return {readCommand: READ_COMMANDS.SYNC_POLICY_TO_FINANCIAL_FORCE, stageInProgress: CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.FINANCIAL_FORCE_SYNC_CONNECTION};
143141
}
@@ -158,6 +156,12 @@ function syncConnection(policy: Policy | undefined, connectionName: PolicyConnec
158156
return;
159157
}
160158
const policyID = policy.id;
159+
160+
if (connectionName === CONST.POLICY.CONNECTIONS.NAME.MERGE_HR) {
161+
syncMergeHR(policyID);
162+
return;
163+
}
164+
161165
const syncConnectionData = getSyncConnectionParameters(connectionName);
162166

163167
if (!syncConnectionData) {

0 commit comments

Comments
 (0)