test: align received payment visibility tests with latest behavior

Author: nabi-ebrahimi

src/components/MoneyReportHeaderActions/MoneyReportHeaderSelectionDropdown.tsx

@@ -157,8 +157,17 @@ function MoneyReportHeaderSelectionDropdown({reportID, primaryAction, isReportIn
     const {confirmApproval, handleSubmitReport, shouldBlockSubmit, isBlockSubmitDueToPreventSelfApproval} = useLifecycleActions({
         reportID,
         startApprovedAnimation,
+        startAnimation,
         startSubmittingAnimation,
-        onHoldMenuOpen: (requestType) => openHoldMenu({requestType, onConfirm: () => clearSelectedTransactions(true)}),
+        onHoldMenuOpen: (requestType, onConfirm, paymentType) =>
+            openHoldMenu({
+                requestType,
+                onConfirm: () => {
+                    onConfirm?.();
+                    clearSelectedTransactions(true);
+                },
+                paymentType,
+            }),
     });
 
     const {

src/libs/ReportSecondaryActionUtils.ts

@@ -52,7 +52,6 @@ import {
     canRejectReportAction,
     canUserPerformWriteAction as canUserPerformWriteActionReportUtils,
     doesReportContainRequestsFromMultipleUsers,
-    getMoneyRequestSpendBreakdown,
     getTransactionDetails,
     hasExportError as hasExportErrorUtils,
     hasOnlyHeldExpenses,

tests/unit/ReportSecondaryActionUtilsTest.ts

@@ -1363,17 +1363,13 @@ describe('getSecondaryAction', () => {
             ownerAccountID: EMPLOYEE_ACCOUNT_ID,
             stateNum: CONST.REPORT.STATE_NUM.APPROVED,
             statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
+            total: -100,
+            nonReimbursableTotal: 0,
         } as unknown as Report;
         const policy = {
             role: CONST.POLICY.ROLE.USER,
         } as unknown as Policy;
 
-        jest.spyOn(ReportUtils, 'getMoneyRequestSpendBreakdown').mockReturnValue({
-            totalDisplaySpend: 100,
-            reimbursableSpend: 100,
-            nonReimbursableSpend: 0,
-        });
-
         const result = getSecondaryReportActions({
             currentUserLogin: EMPLOYEE_EMAIL,
             currentUserAccountID: EMPLOYEE_ACCOUNT_ID,
@@ -1389,24 +1385,20 @@ describe('getSecondaryAction', () => {
         expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.RECEIVED_PAYMENT)).toBe(true);
     });
 
-    it('does not include RECEIVED_PAYMENT option for fully non-reimbursable expense report', () => {
+    it('includes RECEIVED_PAYMENT option for negative expense report even when non-reimbursable total matches total', () => {
         const report = {
             reportID: REPORT_ID,
             type: CONST.REPORT.TYPE.EXPENSE,
             ownerAccountID: EMPLOYEE_ACCOUNT_ID,
             stateNum: CONST.REPORT.STATE_NUM.APPROVED,
             statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
+            total: -100,
+            nonReimbursableTotal: -100,
         } as unknown as Report;
         const policy = {
             role: CONST.POLICY.ROLE.USER,
         } as unknown as Policy;
 
-        jest.spyOn(ReportUtils, 'getMoneyRequestSpendBreakdown').mockReturnValue({
-            totalDisplaySpend: 100,
-            reimbursableSpend: 0,
-            nonReimbursableSpend: 100,
-        });
-
         const result = getSecondaryReportActions({
             currentUserLogin: EMPLOYEE_EMAIL,
             currentUserAccountID: EMPLOYEE_ACCOUNT_ID,
@@ -1419,7 +1411,7 @@ describe('getSecondaryAction', () => {
             policy,
             reportActions: [],
         });
-        expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.RECEIVED_PAYMENT)).toBe(false);
+        expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.RECEIVED_PAYMENT)).toBe(true);
     });
 
     it('does not include RECEIVED_PAYMENT option for admin', () => {
@@ -1429,17 +1421,13 @@ describe('getSecondaryAction', () => {
             ownerAccountID: EMPLOYEE_ACCOUNT_ID,
             stateNum: CONST.REPORT.STATE_NUM.APPROVED,
             statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
+            total: -100,
+            nonReimbursableTotal: 0,
         } as unknown as Report;
         const policy = {
             role: CONST.POLICY.ROLE.ADMIN,
         } as unknown as Policy;
 
-        jest.spyOn(ReportUtils, 'getMoneyRequestSpendBreakdown').mockReturnValue({
-            totalDisplaySpend: 100,
-            reimbursableSpend: 100,
-            nonReimbursableSpend: 0,
-        });
-
         const result = getSecondaryReportActions({
             currentUserLogin: EMPLOYEE_EMAIL,
             currentUserAccountID: EMPLOYEE_ACCOUNT_ID,
@@ -1462,6 +1450,8 @@ describe('getSecondaryAction', () => {
             ownerAccountID: EMPLOYEE_ACCOUNT_ID,
             stateNum: CONST.REPORT.STATE_NUM.APPROVED,
             statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
+            total: -100,
+            nonReimbursableTotal: 0,
         } as unknown as Report;
         const policy = {
             role: CONST.POLICY.ROLE.USER,
@@ -1474,12 +1464,6 @@ describe('getSecondaryAction', () => {
             },
         } as unknown as ReportAction;
 
-        jest.spyOn(ReportUtils, 'getMoneyRequestSpendBreakdown').mockReturnValue({
-            totalDisplaySpend: 100,
-            reimbursableSpend: 100,
-            nonReimbursableSpend: 0,
-        });
-
         const result = getSecondaryReportActions({
             currentUserLogin: EMPLOYEE_EMAIL,
             currentUserAccountID: EMPLOYEE_ACCOUNT_ID,
@@ -1502,6 +1486,8 @@ describe('getSecondaryAction', () => {
             ownerAccountID: EMPLOYEE_ACCOUNT_ID,
             stateNum: CONST.REPORT.STATE_NUM.APPROVED,
             statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,
+            total: -100,
+            nonReimbursableTotal: 0,
         } as unknown as Report;
         const policy = {
             role: CONST.POLICY.ROLE.USER,
@@ -1514,12 +1500,6 @@ describe('getSecondaryAction', () => {
             },
         } as unknown as ReportAction;
 
-        jest.spyOn(ReportUtils, 'getMoneyRequestSpendBreakdown').mockReturnValue({
-            totalDisplaySpend: 100,
-            reimbursableSpend: 100,
-            nonReimbursableSpend: 0,
-        });
-
         const result = getSecondaryReportActions({
             currentUserLogin: EMPLOYEE_EMAIL,
             currentUserAccountID: EMPLOYEE_ACCOUNT_ID,