Merge pull request Expensify#68841 from lorretheboy/fix/67609

Account owner's name is missing in type:chat from: suggestions

Author: luacmartins

src/components/Search/SearchAutocompleteList.tsx

@@ -346,7 +346,7 @@ function SearchAutocompleteList(
             case CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM:
             case CONST.SEARCH.SYNTAX_FILTER_KEYS.PAYER:
             case CONST.SEARCH.SYNTAX_FILTER_KEYS.EXPORTER: {
-                const participants = getSearchOptions(options, betas ?? [], true, true, autocompleteValue, 10, false, false).personalDetails.filter(
+                const participants = getSearchOptions(options, betas ?? [], true, true, autocompleteValue, 10, false, false, true).personalDetails.filter(
                     (participant) => participant.text && !alreadyAutocompletedKeys.includes(participant.text.toLowerCase()),
                 );
 

src/libs/OptionsListUtils.ts

@@ -2077,6 +2077,7 @@ function getSearchOptions(
     maxResults?: number,
     includeUserToInvite?: boolean,
     includeRecentReports = true,
+    includeCurrentUser = false,
 ): Options {
     Timing.start(CONST.TIMING.LOAD_SEARCH_OPTIONS);
     Performance.markStart(CONST.TIMING.LOAD_SEARCH_OPTIONS);
@@ -2095,6 +2096,7 @@ function getSearchOptions(
         shouldBoldTitleByDefault: !isUsedInChatFinder,
         excludeHiddenThreads: true,
         maxElements: maxResults,
+        includeCurrentUser,
         searchString: searchQuery,
         includeUserToInvite,
     });

tests/unit/OptionsListUtilsTest.tsx

@@ -622,6 +622,34 @@ describe('OptionsListUtils', () => {
             // Then all of the reports should be shown including the archived rooms, except for the thread report with notificationPreferences hidden.
             expect(results.recentReports.length).toBe(Object.values(OPTIONS.reports).length - 1);
         });
+
+        it('should include current user when includeCurrentUser is true for type:chat from suggestions', () => {
+            // Given a set of options where the current user is Iron Man (accountID: 2)
+            // When we call getSearchOptions with includeCurrentUser set to true
+            const results = getSearchOptions(OPTIONS, [CONST.BETAS.ALL], true, true, '', undefined, false, true, true);
+
+            // Then the current user should be included in personalDetails
+            const currentUserOption = results.personalDetails.find((option) => option.login === 'tonystark@expensify.com');
+            expect(currentUserOption).toBeDefined();
+            expect(currentUserOption?.text).toBe('Iron Man');
+            expect(currentUserOption?.accountID).toBe(2);
+
+            // Then all personal details including the current user should be returned
+            expect(results.personalDetails.length).toBe(10);
+        });
+
+        it('should exclude current user when includeCurrentUser is false', () => {
+            // Given a set of options where the current user is Iron Man (accountID: 2)
+            // When we call getSearchOptions with includeCurrentUser set to false (default behavior)
+            const results = getSearchOptions(OPTIONS, [CONST.BETAS.ALL], true, true, '', undefined, false, true, false);
+
+            // Then the current user should not be included in personalDetails
+            const currentUserOption = results.personalDetails.find((option) => option.login === 'tonystark@expensify.com');
+            expect(currentUserOption).toBeUndefined();
+
+            // Then all personal details except the current user should be returned
+            expect(results.personalDetails.length).toBe(9);
+        });
     });
 
     describe('orderOptions()', () => {