Skip to content

Commit a377141

Browse files
committed
Merge branch 'main' of https://github.com/Expensify/App into travelEnablement
2 parents ec8e076 + 958da4f commit a377141

87 files changed

Lines changed: 1742 additions & 813 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Mobile-Expensify

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ android {
114114
minSdkVersion rootProject.ext.minSdkVersion
115115
targetSdkVersion rootProject.ext.targetSdkVersion
116116
multiDexEnabled rootProject.ext.multiDexEnabled
117-
versionCode 1009023000
118-
versionName "9.2.30-0"
117+
versionCode 1009023100
118+
versionName "9.2.31-0"
119119
// Supported language variants must be declared here to avoid from being removed during the compilation.
120120
// This also helps us to not include unnecessary language variants in the APK.
121121
resConfigs "en", "es"

assets/images/camera.svg

Lines changed: 1 addition & 1 deletion
Loading

assets/images/plus-circle.svg

Lines changed: 1 addition & 0 deletions
Loading

contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,28 @@
11
## What is a Contributor+ (C+)?
22
C+ are contributors who are experienced at working with Expensify and have gained the confidence of the internal Expensify team. Accordingly, they are allocated additional opportunities and responsibilities:
3-
- They review proposed solutions in external GitHub issues, validate them, and make recommendations to an internal Contributor Manager Engineer (CME).
4-
- Once a proposal has been accepted by a CME, the C+ will be the first person to review the pull request associated with that proposal.
3+
- They review proposed solutions in external GitHub issues, validate them, and make recommendations to an internal Contributor Manager Engineer (CME).
4+
- Once a proposal has been accepted by a CME, the C+ will be the first person to review the pull request associated with that proposal.
55

66
## Why would someone want to be a C+
7-
- C+ are compensated the same price as the contributor for reviewing proposals and the associated PR. (ie. if a job is listed at $1000, that’s how much the C+ will make if they review both the proposals and PR). If regressions are found that should have* been caught after the PR has been approved, C+ payment is reduced by 50% for each regression found.
7+
- C+ are compensated the same price as the contributor for reviewing proposals and the associated PR. (ie. if a job is listed at $250, that’s how much the C+ will make if they review both the proposals and PR). If regressions are found that should have* been caught after the PR has been approved, C+ payment is reduced by 50% for each regression found.
88
- * Should have = C+ should have caught the bug by fully following the PR checklist. If C+ skips a step or completed the checklist incompletely, payment will be cut in half.
99
- C+ can also work on jobs as a contributor.
1010
- Earning potential is variable, it depends on how much a C+ wants to work and other jobs they’re hired for. We’ve seen C+ make ~$100k/year.
1111
- There isn’t a set number of hours a C+ needs to work in a week. Proposals and PRs reviews are expected to be addressed within 24 hours on weekdays.
12-
- Dedicated #contributor-plus Slack room to discuss issues, processes and proposals.
13-
- If C+ ever applies to work at Expensify, they’ve got a leg up on the competition because they're familiar with the company and processes. View job openings at https://we.are.expensify.com.
12+
- Dedicated #contributor-plus Slack room to discuss issues, processes and proposals.
13+
- Opportunity to work on projects and design docs for new features.
14+
- A contributor must be a C+ to be considered to become a Backend Contributor.
15+
- C+ are already familiar with the team, company, and processes, which may help when applying for full-time roles. One C+ has been hired full-time. View current openings at https://we.are.expensify.com
1416

1517
## Requirements to join C+
16-
- Have had 30 PRs deployed to production without regressions.
18+
- Have had 30 PRs deployed to production.
1719
- Follow our Code of Conduct, Contributing.md and README.md docs and processes.
1820
- Comment and fix bugs in a timely manner.
19-
- Clear communicator
21+
- Clear communicator.
2022
- Bonus points:
2123
- Help other contributors by commenting on their issues.
22-
- Actively involved in the #expensify-open-source slack channel
23-
- Adheres to the PR review guidelines
24+
- Actively involved in the #expensify-open-source slack channel.
25+
- Adheres to the PR review guidelines.
2426

2527
## How to join?
2628

docs/articles/new-expensify/wallet-and-payments/Pay-an-invoice.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Anyone can pay an invoice they’ve received, but only Expensify customers can s
4949

5050
Expensify invoicing is designed to cater to both business-to-customer (B2C) and business-to-business (B2B) needs, making it a versatile tool for businesses of all sizes.
5151

52-
**Can I pay an invoice outside of Expensify**
52+
**Can I pay an invoice outside of Expensify?**
5353

5454
You will need to work with the vendor to discuss alternative payment options. You can chat with your vendor directly at expensify.com in the designated invoice room.
5555

gradleUtils/PatchedArtifactsSettings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def patchedArtifacts = settings.getExtensions().create('patchedArtifacts', Patch
1515

1616
def warnIfNotConfigured(reason) {
1717
ExpensiLog.warn("$reason")
18-
ExpensiLog.warn("For setup instructions, refer to: https://github.com/Expensify/App?tab=readme-ov-file#enabling-prebuilt-react-native-artifacts-on-android")
18+
ExpensiLog.warn("For setup instructions, refer to: https://github.com/Expensify/App/blob/main/contributingGuides/SETUP_ANDROID.md#enabling-prebuilt-react-native-artifacts")
1919
}
2020

2121
def getNewDotRootDir() {

0 commit comments

Comments
 (0)