Treat /Home as empty route instead of guarding with route truthiness

Reverts the route truthiness guard and getAdaptedStateFromPath normalization.
Instead, normalizes the /Home route to empty string early in openReportFromDeepLink,
matching the existing pattern for /signin route handling. This prevents the
"not found" page when React Navigation generates /Home for the root URL.

Co-authored-by: mkhutornyi <mkhutornyi@users.noreply.github.com>

Author: MelvinBot

src/libs/Navigation/helpers/getAdaptedStateFromPath.ts

@@ -411,12 +411,6 @@ const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options, shouldR
         normalizedPath = '/';
     }
 
-    // React Navigation generates /Home (capitalized) for the sign-in page because PublicScreens uses SCREENS.HOME ('Home')
-    // at the root level without a path mapping. Normalize it to the correct lowercase route to avoid “not found” pages.
-    if (normalizedPath.toLowerCase() === `/${ROUTES.HOME}`) {
-        normalizedPath = `/${ROUTES.HOME}`;
-    }
-
     const state = getStateFromPath(normalizedPath as RoutePath) as PartialState<NavigationState<RootNavigatorParamList>>;
     if (shouldReplacePathInNestedState) {
         replacePathInNestedState(state, normalizedPath);

src/libs/actions/Link.ts

@@ -262,6 +262,12 @@ function openReportFromDeepLink(
         route = '';
     }
 
+    // React Navigation generates /Home (capitalized) for the root URL because PublicScreens uses SCREENS.HOME ('Home')
+    // at the root level without a path mapping. Treat it as empty route to avoid showing a “not found” page after sign-in.
+    if (normalizePath(route).toLowerCase() === `/${ROUTES.HOME}`) {
+        route = '';
+    }
+
     // If we are not authenticated and are navigating to a public screen, we don't want to navigate again to the screen after sign-in/sign-up
     if (!isAuthenticated && isPublicScreenRoute(route)) {
         return;
@@ -364,11 +370,7 @@ function openReportFromDeepLink(
                             }
                         };
 
-                        // Guard deeplink navigation with a route truthiness check to prevent navigating to an
-                        // empty route when the user visits the root URL (e.g. new.expensify.com) and then signs in.
-                        // Without this, hasCompletedGuidedSetupFlowSelector returns true for empty onboarding objects
-                        // and Navigation.navigate('') fires, showing a "not found" page.
-                        if ((route && hasCompletedGuidedSetupFlowSelector(val)) || isAnonymousUser()) {
+                        if (hasCompletedGuidedSetupFlowSelector(val) || isAnonymousUser()) {
                             handleDeeplinkNavigation();
                         }
                     });

tests/unit/OnboardingSelectorsTest.ts

@@ -7,27 +7,6 @@ describe('onboardingSelectors', () => {
     // Not all users have this NVP defined as we did not run a migration to backfill it for existing accounts, hence we need to make sure
     // the onboarding flow is only showed to the users with `hasCompletedGuidedSetupFlow` set to false
     describe('hasCompletedGuidedSetupFlowSelector', () => {
-        // Regression test: hasCompletedGuidedSetupFlowSelector returns true for empty onboarding objects (the pre-login default state).
-        // The deeplink guard in Link.ts must combine this with a route truthiness check to prevent navigating to an empty route
-        // when the user visits the root URL and signs in (issue #90880).
-        it('Should return true for empty onboarding (pre-login default), confirming the need for a route check in deeplink navigation', () => {
-            const emptyOnboarding = {} as OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>;
-            const selectorResult = hasCompletedGuidedSetupFlowSelector(emptyOnboarding);
-
-            // The selector returns true for empty objects (old/migrated accounts), which is correct for its own purpose.
-            expect(selectorResult).toBe(true);
-
-            // The deeplink guard must NOT navigate when the route is empty (root URL produces ''),
-            // even if the selector returns true. This is the condition from openReportFromDeepLink:
-            // (route && hasCompletedGuidedSetupFlowSelector(val))
-            const emptyRoute = ''; // root URL produces empty string via getRouteFromLink
-            expect(emptyRoute && selectorResult).toBeFalsy();
-
-            // But when a real deeplink route exists, navigation should proceed
-            const deeplinkRoute = 'concierge';
-            expect(deeplinkRoute && selectorResult).toBeTruthy();
-        });
-
         it('Should return true if onboarding NVP is an empty object', () => {
             const onboarding = {} as OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>;
             expect(hasCompletedGuidedSetupFlowSelector(onboarding)).toBe(true);