Skip to content

Commit aae9642

Browse files
authored
Merge pull request Expensify#65514 from nabi-ebrahimi/fix/reload-resets-workspace-bg
Fix: Reset Background to Workspace on Page Reload in Track Expense
2 parents 2522e90 + 015d296 commit aae9642

6 files changed

Lines changed: 18 additions & 9 deletions

File tree

src/ROUTES.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -602,10 +602,11 @@ const ROUTES = {
602602
},
603603
MONEY_REQUEST_STEP_CONFIRMATION: {
604604
route: ':action/:iouType/confirmation/:transactionID/:reportID/:backToReport?',
605-
getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string | undefined, backToReport?: string, participantsAutoAssigned?: boolean) =>
606-
`${action as string}/${iouType as string}/confirmation/${transactionID}/${reportID}/${backToReport ?? ''}${
607-
participantsAutoAssigned ? '?participantsAutoAssigned=true' : ''
608-
}` as const,
605+
getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string | undefined, backToReport?: string, participantsAutoAssigned?: boolean, backTo?: string) =>
606+
getUrlWithBackToParam(
607+
`${action as string}/${iouType as string}/confirmation/${transactionID}/${reportID}/${backToReport ?? ''}${participantsAutoAssigned ? '?participantsAutoAssigned=true' : ''}`,
608+
backTo,
609+
),
609610
},
610611
MONEY_REQUEST_STEP_AMOUNT: {
611612
route: ':action/:iouType/amount/:transactionID/:reportID/:pageIndex?/:backToReport?',

src/libs/Navigation/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1410,7 +1410,7 @@ type MoneyRequestNavigatorParamList = {
14101410
transactionID: string;
14111411
reportID: string;
14121412
pageIndex?: string;
1413-
backTo?: string;
1413+
backTo?: Routes;
14141414
participantsAutoAssigned?: string;
14151415
backToReport?: string;
14161416
};

src/libs/ReportUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9932,7 +9932,7 @@ function createDraftTransactionAndNavigateToParticipantSelector(
99329932
}
99339933

99349934
if (actionName === CONST.IOU.ACTION.SHARE) {
9935-
Navigation.navigate(ROUTES.MONEY_REQUEST_ACCOUNTANT.getRoute(actionName, CONST.IOU.TYPE.SUBMIT, transactionID, reportID, undefined));
9935+
Navigation.navigate(ROUTES.MONEY_REQUEST_ACCOUNTANT.getRoute(actionName, CONST.IOU.TYPE.SUBMIT, transactionID, reportID, Navigation.getActiveRoute()));
99369936
return;
99379937
}
99389938

src/pages/iou/request/step/IOURequestStepAccountant.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ function IOURequestStepAccountant({
3838
createDraftWorkspaceAndNavigateToConfirmationScreen(transactionID, action);
3939
return;
4040
}
41-
42-
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID, undefined, action));
41+
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID, Navigation.getActiveRoute(), action));
4342
}, [iouType, transactionID, reportID, action, currentUserLogin]);
4443

4544
const navigateBack = useCallback(() => {

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function IOURequestStepConfirmation({
8181
report: reportReal,
8282
reportDraft,
8383
route: {
84-
params: {iouType, reportID, transactionID: initialTransactionID, action, participantsAutoAssigned: participantsAutoAssignedFromRoute, backToReport},
84+
params: {iouType, reportID, transactionID: initialTransactionID, action, participantsAutoAssigned: participantsAutoAssignedFromRoute, backToReport, backTo},
8585
},
8686
transaction: initialTransaction,
8787
isLoadingTransaction,
@@ -299,6 +299,11 @@ function IOURequestStepConfirmation({
299299
}, [transactionIDs, requestType, defaultCategory, policy?.id]);
300300

301301
const navigateBack = useCallback(() => {
302+
if (backTo) {
303+
Navigation.goBack(backTo);
304+
return;
305+
}
306+
302307
// If the action is categorize and there's no policies other than personal one, we simply call goBack(), i.e: dismiss the whole flow together
303308
// We don't need to subscribe to policy_ collection as we only need to check on the latest collection value
304309
if (action === CONST.IOU.ACTION.CATEGORIZE) {
@@ -353,6 +358,7 @@ function IOURequestStepConfirmation({
353358
reportID,
354359
participantsAutoAssignedFromRoute,
355360
isMovingTransactionFromTrackExpense,
361+
backTo,
356362
]);
357363

358364
const navigateToAddReceipt = useCallback(() => {

src/pages/iou/request/step/IOURequestStepParticipants.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,9 @@ function IOURequestStepParticipants({
253253
iouType === CONST.IOU.TYPE.CREATE ? CONST.IOU.TYPE.SUBMIT : iouType,
254254
initialTransactionID,
255255
newReportID,
256+
undefined,
257+
undefined,
258+
Navigation.getActiveRoute(),
256259
);
257260

258261
const route = isCategorizing

0 commit comments

Comments
 (0)