fix: unexpected error submitting test drive expense

Author: pac-guerreiro

src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx

@@ -18,6 +18,7 @@ import {
 } from '@libs/actions/IOU';
 import {verifyTestDriveRecipient} from '@libs/actions/Onboarding';
 import setTestReceipt from '@libs/actions/setTestReceipt';
+import type AccountExistsError from '@libs/Errors/AccountExistsError';
 import Navigation from '@libs/Navigation/Navigation';
 import type {PlatformStackRouteProp} from '@libs/Navigation/PlatformStackNavigation/types';
 import type {TestDriveModalNavigatorParamList} from '@libs/Navigation/types';
@@ -86,13 +87,13 @@ function EmployeeTestDriveModal() {
                     },
                     () => {
                         setIsLoading(false);
-                        setFormError(translate('testDrive.modal.employee.error'));
+                        setFormError(translate('common.genericErrorMessage'));
                     },
                 );
             })
-            .catch(() => {
+            .catch((e: AccountExistsError) => {
                 setIsLoading(false);
-                setFormError(translate('testDrive.modal.employee.error'));
+                setFormError(e.translationKey ? translate(e.translationKey) : 'common.genericErrorMessage');
             });
     };
 

src/languages/en.ts

@@ -616,6 +616,7 @@ const translations = {
         getTheApp: 'Get the app',
         scanReceiptsOnTheGo: 'Scan receipts from your phone',
         headsUp: 'Heads up!',
+        unstableInternetConnection: 'Unstable internet connection. Please check your network and try again.',
     },
     supportalNoAccess: {
         title: 'Not so fast',

src/languages/es.ts

@@ -607,6 +607,7 @@ const translations = {
         getTheApp: 'Descarga la app',
         scanReceiptsOnTheGo: 'Escanea recibos desde tu teléfono',
         headsUp: '¡Atención!',
+        unstableInternetConnection: 'Conexión a internet inestable. Por favor, revisa tu red e inténtalo de nuevo.',
     },
     supportalNoAccess: {
         title: 'No tan rápido',

src/libs/Errors/AccountExistsError.ts

@@ -0,0 +1,13 @@
+import type {TranslationPaths} from '@src/languages/types';
+
+class AccountExistsError extends Error {
+    translationKey: TranslationPaths;
+
+    constructor(accountExists: boolean | undefined) {
+        super();
+        // If accountExists is undefined, it means we couldn't determine the account status due to an unstable internet connection.
+        this.translationKey = accountExists === undefined ? 'common.unstableInternetConnection' : 'testDrive.modal.employee.error';
+    }
+}
+
+export default AccountExistsError;

src/libs/actions/Onboarding.ts

@@ -1,6 +1,7 @@
 import Onyx from 'react-native-onyx';
 import * as API from '@libs/API';
 import {SIDE_EFFECT_REQUEST_COMMANDS} from '@libs/API/types';
+import AccountExistsError from '@libs/Errors/AccountExistsError';
 import ONYXKEYS from '@src/ONYXKEYS';
 
 /**
@@ -34,12 +35,13 @@ function setWorkspaceCurrency(currency: string) {
 function verifyTestDriveRecipient(email: string) {
     // eslint-disable-next-line rulesdir/no-api-side-effects-method
     return API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.VERIFY_TEST_DRIVE_RECIPIENT, {email}).then((response) => {
-        if (!response?.accountExists) {
+        // If accountExists is undefined, it means we couldn't determine the account status due to an unstable internet connection.
+        if (response?.accountExists === false) {
             // We can invite this user since they do not have an account yet
             return;
         }
 
-        throw new Error(response?.message);
+        throw new AccountExistsError(response?.accountExists);
     });
 }