Merge pull request Expensify#72011 from callstack-internal/eslint-9-no-unsafe-call

[NO QA] Eslint9 - fix @typescript-eslint/no-unsafe-call

Author: roryabraham

eslint.config.js

@@ -399,7 +399,6 @@ const config = defineConfig([
             // These rules could indicate potential bugs in the source code.
             // After fixing the source code, remove these so they become errors instead of warnings.
             '@typescript-eslint/no-base-to-string': 'warn',
-            '@typescript-eslint/no-unsafe-call': 'warn',
 
             // @typescript-eslint/lines-between-class-members was moved to @stylistic/eslint-plugin, so replaced with lines-between-class-members.
             'lines-between-class-members': 'error',

scripts/aggregateGitHubDataFromUpwork.ts

@@ -156,7 +156,6 @@ async function getGitHubData() {
             const type = getIssueTypeFromLabels(labels);
             let capSWProjects = '';
             if (type === 'feature') {
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-call
                 capSWProjects = await getProjectsForIssue(issueNumber);
             }
             gitHubData.push({

src/components/AttachmentModal.tsx

@@ -25,6 +25,7 @@ import type {TranslationPaths} from '@src/languages/types';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type * as OnyxTypes from '@src/types/onyx';
+import type {FileObject} from '@src/types/utils/Attachment';
 import {isEmptyObject} from '@src/types/utils/EmptyObject';
 import viewRef from '@src/types/utils/viewRef';
 import AttachmentCarousel from './Attachments/AttachmentCarousel';
@@ -48,17 +49,6 @@ import SafeAreaConsumer from './SafeAreaConsumer';
  * to display a full size image or PDF modally with optional confirmation button.
  */
 
-type ImagePickerResponse = {
-    height?: number;
-    name: string;
-    size?: number | null;
-    type: string;
-    uri: string;
-    width?: number;
-};
-
-type FileObject = Partial<File | ImagePickerResponse>;
-
 type ChildrenProps = {
     show: () => void;
 };
@@ -603,5 +593,3 @@ function AttachmentModal({
 AttachmentModal.displayName = 'AttachmentModal';
 
 export default memo(AttachmentModal);
-
-export type {FileObject, ImagePickerResponse};

src/components/AttachmentPicker/index.native.tsx

@@ -19,9 +19,9 @@ import useStyleUtils from '@hooks/useStyleUtils';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import {cleanFileName, resizeImageIfNeeded, showCameraPermissionsAlert, verifyFileFormat} from '@libs/fileDownload/FileUtils';
-import type {FileObject, ImagePickerResponse as FileResponse} from '@pages/media/AttachmentModalScreen/types';
 import CONST from '@src/CONST';
 import type {TranslationPaths} from '@src/languages/types';
+import type {FileObject, ImagePickerResponse as FileResponse} from '@src/types/utils/Attachment';
 import type IconAsset from '@src/types/utils/IconAsset';
 import launchCamera from './launchCamera/launchCamera';
 import type AttachmentPickerProps from './types';

src/components/AttachmentPicker/index.tsx

@@ -2,8 +2,8 @@ import React, {useRef} from 'react';
 import type {ValueOf} from 'type-fest';
 import {isMobileChrome} from '@libs/Browser';
 import Visibility from '@libs/Visibility';
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
 import CONST from '@src/CONST';
+import type {FileObject} from '@src/types/utils/Attachment';
 import type AttachmentPickerProps from './types';
 
 /**

src/components/AttachmentPicker/types.ts

@@ -1,7 +1,7 @@
 import type {ReactNode} from 'react';
 import type {ValueOf} from 'type-fest';
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
 import type CONST from '@src/CONST';
+import type {FileObject} from '@src/types/utils/Attachment';
 
 type PickerOptions = {
     /** A callback that will be called with the selected attachments. */

src/components/Attachments/types.ts

@@ -1,4 +1,4 @@
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
+import type {FileObject} from '@src/types/utils/Attachment';
 import type IconAsset from '@src/types/utils/IconAsset';
 
 type AttachmentSource = string | IconAsset | number;

src/components/AvatarWithImagePicker.tsx

@@ -9,10 +9,10 @@ import {validateAvatarImage} from '@libs/AvatarUtils';
 import {isSafari} from '@libs/Browser';
 import type {CustomRNImageManipulatorResult} from '@libs/cropOrRotateImage/types';
 import type {AvatarSource} from '@libs/UserUtils';
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
 import CONST from '@src/CONST';
 import type {TranslationPaths} from '@src/languages/types';
 import type * as OnyxCommon from '@src/types/onyx/OnyxCommon';
+import type {FileObject} from '@src/types/utils/Attachment';
 import type IconAsset from '@src/types/utils/IconAsset';
 import AttachmentModal from './AttachmentModal';
 import AttachmentPicker from './AttachmentPicker';

src/components/Composer/implementation/index.native.tsx

@@ -14,9 +14,9 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import {containsOnlyEmojis} from '@libs/EmojiUtils';
 import {splitExtensionFromFileName} from '@libs/fileDownload/FileUtils';
 import Parser from '@libs/Parser';
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
 import getFileSize from '@pages/Share/getFileSize';
 import CONST from '@src/CONST';
+import type {FileObject} from '@src/types/utils/Attachment';
 
 const excludeNoStyles: Array<keyof MarkdownStyle> = [];
 const excludeReportMentionStyle: Array<keyof MarkdownStyle> = ['mentionReport'];

src/components/Composer/types.ts

@@ -1,5 +1,5 @@
 import type {NativeSyntheticEvent, StyleProp, TextInputProps, TextInputSelectionChangeEventData, TextStyle} from 'react-native';
-import type {FileObject} from '@pages/media/AttachmentModalScreen/types';
+import type {FileObject} from '@src/types/utils/Attachment';
 
 type TextSelection = {
     start: number;