Skip to content

Commit ae3c936

Browse files
committed
fix: extract onPress handler to useCallback in ApprovalWorkflowEditor
1 parent f4bd906 commit ae3c936

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,10 @@ function ApprovalWorkflowEditor({approvalWorkflow, removeApprovalWorkflow, polic
119119
[approvalWorkflow.action, policyID],
120120
);
121121

122+
const handleExpensesFromPress = useCallback(() => {
123+
Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM.getRoute(policyID));
124+
}, [policyID]);
125+
122126
// User should be allowed to add additional approver only if they upgraded to Control Plan, otherwise redirected to the Upgrade Page
123127
const addAdditionalApprover = useCallback(() => {
124128
if (!isControlPolicy(policy) && approverCount > 0) {
@@ -151,7 +155,7 @@ function ApprovalWorkflowEditor({approvalWorkflow, removeApprovalWorkflow, polic
151155
numberOfLinesTitle={4}
152156
description={translate('workflowsExpensesFromPage.title')}
153157
descriptionTextStyle={!!members && styles.textLabelSupportingNormal}
154-
onPress={() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM.getRoute(policyID))}
158+
onPress={handleExpensesFromPress}
155159
wrapperStyle={[styles.sectionMenuItemTopDescription]}
156160
errorText={approvalWorkflow?.errors?.members ? translate(approvalWorkflow.errors.members) : undefined}
157161
brickRoadIndicator={approvalWorkflow?.errors?.members ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}

0 commit comments

Comments
 (0)