Skip to content

Commit ae8bbbe

Browse files
authored
Merge pull request Expensify#67498 from software-mansion-labs/jakubkalinski0/Incorrect-Animation-Direction-for-Expense-Preview-Skeleton
Fixed wrong animation direction of a skeleton by removing mirror
2 parents 1dc1b1d + c833be4 commit ae8bbbe

1 file changed

Lines changed: 8 additions & 11 deletions

File tree

src/components/TransactionPreviewSkeletonView.tsx

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ function TransactionPreviewSkeletonView({transactionPreviewWidth}: TransactionPr
1414
const theme = useTheme();
1515
const styles = useThemeStyles();
1616

17-
const isWidthANumber = typeof transactionPreviewWidth === 'number';
18-
const width = isWidthANumber ? transactionPreviewWidth - styles.p4.padding * 2 : transactionPreviewWidth;
1917
const height = variables.transactionPreviewSkeletonHeight;
18+
const widthOfTheLeftSkeleton = 120;
19+
const widthOfTheRightSkeleton = 68;
2020

2121
return (
22-
<View style={[styles.p4, styles.mtn1]}>
22+
<View style={[styles.p4, styles.mtn1, styles.justifyContentBetween, {width: transactionPreviewWidth}]}>
2323
<SkeletonViewContentLoader
2424
testID={TransactionPreviewSkeletonView.displayName}
2525
animate
26-
width={width}
26+
width={widthOfTheLeftSkeleton}
2727
height={height}
2828
backgroundColor={theme.skeletonLHNIn}
2929
foregroundColor={theme.skeletonLHNOut}
@@ -37,7 +37,7 @@ function TransactionPreviewSkeletonView({transactionPreviewWidth}: TransactionPr
3737
<Rect
3838
x="0"
3939
y="24"
40-
width="120"
40+
width={widthOfTheLeftSkeleton}
4141
height="20"
4242
/>
4343
<Rect
@@ -47,20 +47,17 @@ function TransactionPreviewSkeletonView({transactionPreviewWidth}: TransactionPr
4747
height="7"
4848
/>
4949
</SkeletonViewContentLoader>
50-
{/* This skeleton inverts the progress bar, which should be on the right,
51-
so we don't need to know the width of the component to calculate it - works with percentages.
52-
*/}
53-
<View style={[styles.r0, styles.b0, styles.p4, styles.mtn1, styles.pAbsolute, styles.mirror]}>
50+
<View style={[styles.r0, styles.b0, styles.p4, styles.mtn1, styles.pAbsolute]}>
5451
<SkeletonViewContentLoader
55-
width={width}
52+
width={widthOfTheRightSkeleton}
5653
height={height}
5754
foregroundColor={theme.skeletonLHNOut}
5855
backgroundColor={theme.skeletonLHNIn}
5956
>
6057
<Rect
6158
x="0"
6259
y="24"
63-
width="68"
60+
width={widthOfTheRightSkeleton}
6461
height="20"
6562
/>
6663
</SkeletonViewContentLoader>

0 commit comments

Comments
 (0)