Fix: remove duplicate Onyx subscriptions causing perf test render regression

The guard had its own connectWithoutView for SESSION and IS_LOADING_APP,
duplicating the ones in guards/index.ts. The extra Onyx connections caused
an additional render in the SidebarLinks perf test (render count +1).

Instead, guards/index.ts now calls onSessionOrLoadingAppChanged() in its
existing callbacks to pass the values through to the guard.

Co-authored-by: Eric Han <eh2077@users.noreply.github.com>

Author: MelvinBot

src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts

@@ -45,21 +45,16 @@ function navigateToMigratedUserWelcomeModalIfReady() {
     Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute());
 }
 
-Onyx.connectWithoutView({
-    key: ONYXKEYS.SESSION,
-    callback: (value) => {
-        session = value;
-        navigateToMigratedUserWelcomeModalIfReady();
-    },
-});
-
-Onyx.connectWithoutView({
-    key: ONYXKEYS.IS_LOADING_APP,
-    callback: (value) => {
-        isLoadingApp = value ?? true;
-        navigateToMigratedUserWelcomeModalIfReady();
-    },
-});
+/**
+ * Called by guards/index.ts when session or loading app state changes.
+ * Reuses the shared Onyx subscriptions from guards/index.ts to avoid duplicate connections
+ * that cause extra renders in performance tests.
+ */
+function onSessionOrLoadingAppChanged(sessionValue: OnyxEntry<Session>, isLoadingAppValue: boolean) {
+    session = sessionValue;
+    isLoadingApp = isLoadingAppValue;
+    navigateToMigratedUserWelcomeModalIfReady();
+}
 
 Onyx.connectWithoutView({
     key: ONYXKEYS.NVP_TRY_NEW_DOT,
@@ -138,4 +133,4 @@ const MigratedUserWelcomeModalGuard: NavigationGuard = {
 };
 
 export default MigratedUserWelcomeModalGuard;
-export {resetSessionFlag};
+export {resetSessionFlag, onSessionOrLoadingAppChanged};

src/libs/Navigation/guards/index.ts

@@ -4,7 +4,7 @@ import type {OnyxEntry} from 'react-native-onyx';
 import getCurrentUrl from '@libs/Navigation/currentUrl';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {Session} from '@src/types/onyx';
-import MigratedUserWelcomeModalGuard from './MigratedUserWelcomeModalGuard';
+import MigratedUserWelcomeModalGuard, {onSessionOrLoadingAppChanged} from './MigratedUserWelcomeModalGuard';
 import OnboardingGuard from './OnboardingGuard';
 import type {GuardContext, GuardResult, NavigationGuard} from './types';
 
@@ -19,13 +19,15 @@ Onyx.connectWithoutView({
     key: ONYXKEYS.SESSION,
     callback: (value) => {
         session = value;
+        onSessionOrLoadingAppChanged(session, isLoadingApp);
     },
 });
 
 Onyx.connectWithoutView({
     key: ONYXKEYS.IS_LOADING_APP,
     callback: (value) => {
         isLoadingApp = value ?? true;
+        onSessionOrLoadingAppChanged(session, isLoadingApp);
     },
 });