Merge pull request Expensify#89401 from paulnjs/paulnjs-fix/88454

fix: Split action does not trigger paywall in expired workspace

Author: cristipaval

src/libs/actions/SplitExpenses.ts

@@ -6,11 +6,12 @@ import isSearchTopmostFullScreenRoute from '@libs/Navigation/helpers/isSearchTop
 import Navigation from '@libs/Navigation/Navigation';
 import {rand64} from '@libs/NumberUtils';
 import {getTransactionDetails, isOpenReport} from '@libs/ReportUtils';
+import {shouldRestrictUserBillableActions} from '@libs/SubscriptionUtils';
 import {buildOptimisticTransaction, getChildTransactions, getOriginalTransactionWithSplitInfo, isDistanceRequest} from '@libs/TransactionUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
-import type {Policy, Report, Transaction} from '@src/types/onyx';
+import type {BillingGraceEndPeriod, Policy, Report, Transaction} from '@src/types/onyx';
 import type {Attendee} from '@src/types/onyx/IOU';
 import type {TransactionCustomUnit} from '@src/types/onyx/Transaction';
 import {initSplitExpenseItemData, updateSplitExpenseDistanceFromAmount} from './IOU/SplitExpenseItems';
@@ -35,14 +36,47 @@ Onyx.connectWithoutView({
     callback: (value) => (allReports = value),
 });
 
+let ownerBillingGracePeriodEnd: OnyxEntry<number>;
+// We use connectWithoutView because `initSplitExpense` doesn't affect the UI rendering and
+// this avoids unnecessary re-rendering for components when owner billing grace period changes. This data should ONLY
+// be used for `initSplitExpense`
+Onyx.connectWithoutView({
+    key: ONYXKEYS.NVP_PRIVATE_OWNER_BILLING_GRACE_PERIOD_END,
+    callback: (value) => (ownerBillingGracePeriodEnd = value),
+});
+
+let userBillingGracePeriodEnds: OnyxCollection<BillingGraceEndPeriod>;
+// We use connectWithoutView because `initSplitExpense` doesn't affect the UI rendering and
+// this avoids unnecessary re-rendering for components when user billing grace periods change. This data should ONLY
+// be used for `initSplitExpense`
+Onyx.connectWithoutView({
+    key: ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_USER_BILLING_GRACE_PERIOD_END,
+    waitForCollectionCallback: true,
+    callback: (value) => (userBillingGracePeriodEnds = value),
+});
+
+let amountOwed: OnyxEntry<number>;
+// We use connectWithoutView because `initSplitExpense` doesn't affect the UI rendering and
+// this avoids unnecessary re-rendering for components when amount owed changes. This data should ONLY
+// be used for `initSplitExpense`
+Onyx.connectWithoutView({
+    key: ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED,
+    callback: (value) => (amountOwed = value),
+});
+
 /**
  * Create a draft transaction to set up split expense details for the split expense flow
  */
-function initSplitExpense(transaction: OnyxEntry<Transaction>, policy?: OnyxEntry<Policy>): void {
+function initSplitExpense(transaction: OnyxEntry<Transaction>, policy: OnyxEntry<Policy>): void {
     if (!transaction) {
         return;
     }
 
+    if (!!policy && shouldRestrictUserBillableActions(policy, ownerBillingGracePeriodEnd, userBillingGracePeriodEnds, amountOwed)) {
+        Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(policy.id));
+        return;
+    }
+
     const reportID = transaction.reportID ?? String(CONST.DEFAULT_NUMBER_ID);
     const originalTransactionID = transaction?.comment?.originalTransactionID;
     const originalTransaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${originalTransactionID}`];

tests/actions/IOUTest/SplitTest.ts

@@ -4770,7 +4770,7 @@ describe('initSplitExpense', () => {
             reportID: '456',
         };
 
-        initSplitExpense(transaction);
+        initSplitExpense(transaction, undefined);
         await waitForBatchedUpdates();
 
         const draftTransaction = await getOnyxValue(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction.transactionID}`);
@@ -4795,7 +4795,7 @@ describe('initSplitExpense', () => {
     });
     it('should not initialize split expense for null transaction', async () => {
         const transaction: Transaction | undefined = undefined;
-        initSplitExpense(transaction);
+        initSplitExpense(transaction, undefined);
         await waitForBatchedUpdates();
 
         expect(transaction).toBeFalsy();
@@ -4819,7 +4819,7 @@ describe('initSplitExpense', () => {
             reportID: '456',
         };
 
-        initSplitExpense(transaction);
+        initSplitExpense(transaction, undefined);
         await waitForBatchedUpdates();
 
         const draftTransaction = await getOnyxValue(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transaction.transactionID}`);