Skip to content

Commit b6051bf

Browse files
committed
update test cases to not expect deployer fyi message
1 parent 2ef8943 commit b6051bf

2 files changed

Lines changed: 1 addition & 10 deletions

File tree

.github/libs/GithubUtils.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,10 +357,6 @@ class GithubUtils {
357357

358358
issueBody += '\r\n';
359359

360-
// Warn deployers about potential bugs with the new process
361-
issueBody +=
362-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
363-
364360
// PR list
365361
if (sortedPRList.length > 0) {
366362
issueBody += '\r\n**This release contains changes from the following pull requests:**\r\n';

tests/unit/GithubUtilsTest.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -411,13 +411,8 @@ describe('GithubUtils', () => {
411411

412412
const baseDeployBlockerList = [`https://github.com/${process.env.GITHUB_REPOSITORY}/pull/3`, `https://github.com/${process.env.GITHUB_REPOSITORY}/issues/4`];
413413

414-
// Add the new warning message that was added to the GithubUtils
415-
// cspell:disable
416-
const deployerFYIMessage =
417-
'> 💡 **Deployer FYI:** This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent [deploy workflow](https://github.com/Expensify/App/actions/workflows/deploy.yml) labeled `staging`, in the `createChecklist` action. Please tag @Julesssss with any issues.\r\n\r\n';
418-
// cspell:enable
419414
// eslint-disable-next-line max-len
420-
const baseExpectedOutput = `**Release Version:** \`${tag}\`\r\n**Compare Changes:** https://github.com/${process.env.GITHUB_REPOSITORY}/compare/production...staging\r\n\r\n${deployerFYIMessage}\r\n**This release contains changes from the following pull requests:**\r\n`;
415+
const baseExpectedOutput = `**Release Version:** \`${tag}\`\r\n**Compare Changes:** https://github.com/${process.env.GITHUB_REPOSITORY}/compare/production...staging\r\n\r\n**This release contains changes from the following pull requests:**\r\n`;
421416
const openCheckbox = '- [ ] ';
422417
const closedCheckbox = '- [x] ';
423418
const ccApplauseLeads = 'cc @Expensify/applauseleads\r\n';

0 commit comments

Comments
 (0)