Skip to content

Commit b7ca122

Browse files
Merge pull request Expensify#66914 from Expensify/revert-66039-feat/more-3-right-docked-reanimated-modals
[CP Staging] Revert "Migrate more right-docked modals to Reanimated"
2 parents 0d83651 + 67d62fc commit b7ca122

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/components/PushRowWithModal/PushRowModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function PushRowModal({isVisible, selectedOption, onOptionChange, onClose, optio
7777
type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
7878
onModalHide={handleClose}
7979
shouldUseCustomBackdrop
80-
shouldUseReanimatedModal
80+
useNativeDriver
8181
>
8282
<ScreenWrapper
8383
includePaddingTop={false}

src/components/TimeModalPicker.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ function TimeModalPicker({value, errorText, label, onInputChange = () => {}}: Ti
5555
isVisible={isPickerVisible}
5656
onClose={hidePickerModal}
5757
onModalHide={hidePickerModal}
58+
hideModalContentWhileAnimating
59+
useNativeDriver
5860
enableEdgeToEdgeBottomSafeAreaPadding
59-
shouldUseReanimatedModal
6061
>
6162
<ScreenWrapper
6263
style={styles.pb0}

src/components/ValuePicker/ValueSelectorModal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ function ValueSelectorModal({
2323
isVisible={isVisible}
2424
onClose={() => onClose?.()}
2525
onModalHide={onClose}
26+
hideModalContentWhileAnimating
27+
useNativeDriver
2628
onBackdropPress={onBackdropPress}
2729
shouldHandleNavigationBack
2830
enableEdgeToEdgeBottomSafeAreaPadding
29-
shouldUseReanimatedModal
3031
>
3132
<ScreenWrapper
3233
includePaddingTop={false}

src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListSelectorModal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,10 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
7070
isVisible={isVisible}
7171
onClose={onClose}
7272
onModalHide={onClose}
73+
hideModalContentWhileAnimating
74+
useNativeDriver
7375
onBackdropPress={onBackdropPress}
7476
enableEdgeToEdgeBottomSafeAreaPadding
75-
shouldUseReanimatedModal
7677
>
7778
<ScreenWrapper
7879
includePaddingTop={false}

0 commit comments

Comments
 (0)